Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Changes comments/references for visualization install #289

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jan 28, 2023

Changing references of:

pip install sf-hamilton[visualization]
to:
pip install "sf-hamilton[visualization]"

Because zsh users need the quotes, and the quotes
are backwards compatible with bash so I'm thinking this is the better way to list it.

Changes

  • just documentation changes

How I tested this

  • N/A

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Changing references of:
> pip install sf-hamilton[visualization]
to:
> pip install "sf-hamilton[visualization]"

Because zsh users need the quotes, and the quotes
are backwards compatible with bash so I'm thinking
this is the better way to list it.
@skrawcz skrawcz requested a review from elijahbenizzy January 28, 2023 01:06
Was missing import; flagged in #288.
@skrawcz skrawcz merged commit 0bd6ad1 into main Jan 28, 2023
@skrawcz skrawcz deleted the update_viz_install_docs branch January 28, 2023 01:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants