forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run storybook without error #2
Closed
Anaslancer
wants to merge
10,000
commits into
stitesExpensify:main
from
Anaslancer:run-storybook-without-error
Closed
Run storybook without error #2
Anaslancer
wants to merge
10,000
commits into
stitesExpensify:main
from
Anaslancer:run-storybook-without-error
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch-suffix-ukkonen-tree [CP Staging] Revert "Search suffix tree implementation"
fix: report header has "Hold" action when the expense is already in Hold status
…iro/feature/49600-show-reason-for-rbr-gbr-on-lhn-tabs [Debug Mode] Show reason for RBR/GBR on LHN tabs
…ure-page-leads-to-ws-list-page
[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat
…ad-of-isSmallScreenWidth-eslint-rule
fix: The selected approver has no background color
…o-lhn-debugging # Conflicts: # src/languages/en.ts # src/languages/es.ts
…iro/feature/50665-add-rbr-reason-to-lhn-debugging Add RBR reason to LHN debugging
…-nested-state Replace with correct path in nested state
workspace invite submit
…-sound-offline Resolves offline sound playback by caching assets locally
…wdot-travel-page-on-olddot Revert "[HybridApp] Allow classic experience users to use NewDot travel page"
…roll-video-playback-speed-while-fullscreen Fix can't scroll video playback speed when fullscreen
Update and rename adding-payment-card-subscription-overview.md to Add…
…-spinner-if-data-is-already-there fix: do not show spinner if data is already there
…d-perf-analytics-with-policy Add active policy type and role to perf metadata
…d-action-always-on-top Sort to ensure the `CREATED` action is always on top
…message-keeps-reappearing
…add-hybrid-app-to-aasa-file Add HybridApp to Apple App Site Association file
[CP Staging] [NO QA]: Add bank urls to Company Card flow
fix: invoice thread report displays in invoice participants list in offline
…id/bump-react-native-live-markdown-0.1.176 Bump react-native-live-markdown version to 0.1.176
Add images to QBD HelpDot sites
…-logs feat: `react-native-app-logs` integration
…cking [NO QA] Merge the attendee tracking changes, but block use
…swipe-attachment-when-zoomed-in Fix able to swipe attachment when PDF is zoomed in
fix: in offline approver selected is not greyed out
Adding a space after the period to accommodate a second sentence in certain cases
[NO QA] Update Connect-to-Xero.md
…mHeightTo52px Updated the height of the LHN navigation items from 56px to 52px.
…oggle [Internal QA]: Add News toggle to Support account
…patch-2 Update en.ts
[No QA]Only run cla on open and synchronize
Cannot submit survey after pressing Enter
(cherry picked from commit 904e715)
…angeToBumpApp [NO QA] Minor formatting alignment (cherry picked from commit 3a3f182) (CP triggered by Julesssss)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I've added the initializations for the React Navigation when
isJestEnv
is false in this file.Fixed Issues
$ Expensify#51108
PROPOSAL: Expensify#51108 (comment)
Tests
npm run storybook
npm run storybook
.Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android