Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run storybook without error #2

Closed

Conversation

Anaslancer
Copy link

Details

I've added the initializations for the React Navigation when isJestEnv is false in this file.

Fixed Issues

$ Expensify#51108
PROPOSAL: Expensify#51108 (comment)

Tests

  1. Open the Command Prompt or Terminal
  2. Go to the folder that includes the code base.
  3. Run this command, npm run storybook
  4. After build, Open the Web browser and type the link occurred by npm run storybook.
  5. Confirm if the storybook run without error.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android / native
    • Android / Chrome
    • iOS / native
    • iOS / Safari
    • MacOS / Chrome / Safari
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

378082187-80c53afe-cab6-49df-8320-7c1b2be06164

Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android

kubabutkiewicz and others added 30 commits October 21, 2024 15:26
…earch-suffix-ukkonen-tree

[CP Staging] Revert "Search suffix tree implementation"
fix: report header has "Hold" action when the expense is already in Hold status
…iro/feature/49600-show-reason-for-rbr-gbr-on-lhn-tabs

[Debug Mode] Show reason for RBR/GBR on LHN tabs
[Feat] Make it possible to submit expenses to any workspace, whether or not there is a workspace chat
fix: The selected approver has no background color
…o-lhn-debugging

# Conflicts:
#	src/languages/en.ts
#	src/languages/es.ts
…iro/feature/50665-add-rbr-reason-to-lhn-debugging

Add RBR reason to LHN debugging
…-nested-state

Replace with correct path in nested state
…-sound-offline

Resolves offline sound playback by caching assets locally
…wdot-travel-page-on-olddot

Revert "[HybridApp] Allow classic experience users to use NewDot travel page"
…roll-video-playback-speed-while-fullscreen

Fix can't scroll video playback speed when fullscreen
Update and rename adding-payment-card-subscription-overview.md to Add…
…-spinner-if-data-is-already-there

fix: do not show spinner if data is already there
…d-perf-analytics-with-policy

Add active policy type and role to perf metadata
…d-action-always-on-top

Sort to ensure the `CREATED` action is always on top
narefyev91 and others added 29 commits October 24, 2024 13:50
…add-hybrid-app-to-aasa-file

Add HybridApp to Apple App Site Association file
[CP Staging] [NO QA]: Add bank urls to Company Card flow
fix: invoice thread report displays in invoice participants list in offline
…id/bump-react-native-live-markdown-0.1.176

Bump react-native-live-markdown version to 0.1.176
…-logs

feat: `react-native-app-logs` integration
…cking

[NO QA] Merge the attendee tracking changes, but block use
…swipe-attachment-when-zoomed-in

Fix able to swipe attachment when PDF is zoomed in
fix: in offline approver selected is not greyed out
Adding a space after the period to accommodate a second sentence in certain cases
…mHeightTo52px

Updated the height of the LHN navigation items from 56px to 52px.
…oggle

[Internal QA]: Add News toggle to Support account
[No QA]Only run cla on open and synchronize
Cannot submit survey after pressing Enter
(cherry picked from commit 904e715)
…angeToBumpApp

[NO QA] Minor formatting alignment

(cherry picked from commit 3a3f182)

(CP triggered by Julesssss)
@Anaslancer Anaslancer closed this by deleting the head repository Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.