Update adobe::promote to use fixed width types and remove 64bit Win promote warning #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romote warning. Based on discussion with sparent who said "The code should be written in terms of fixed sized types" and (regarding the warning) "I’m sure the error message is because we had cases of size_t for 32 bits and in the move to 64 bits this broke so we put in the error. Since size_t is not a distinct type this is really just going to generate an error for any 64 bit type on windows. These cases should be removed."
|
See PR #98. |
sean-parent
added a commit
that referenced
this pull request
Jun 20, 2023
- Removed the special case to diagnose Windows 64 vs. macOS 32-bit in convert.hpp Unlike PR Update adobe::promote to use fixed width types and remove 64bit Win promote warning - #96, this doesn't promote char types (the original did not). I'm afraid that would be a breaking change. I promoted all 16 & 32-bit arithmetic types to double to simplify maintenance (convert.hpp). - Fixed all unit tests on Windows (some sha tests are conditionalized because they contain too long strings). - Fixed the CI system (thanks to @camino) - Started working on better VSCode support. - Updated code for C++17 - Removed deprecated calls - Fixed compiler warnings - Removed support for compiling without thread_local variables - Removed some unnecessary uses of boost - Added NOMINMAX to Windows builds --------- Co-authored-by: nickpdemarco <nickpdemarco@gmail.com> Co-authored-by: Dave Abrahams <dabrahams@adobe.com> Co-authored-by: David Sankel <dsankel@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion with @sean-parent who said "The code should be written in terms of fixed sized types" and (regarding the warning) "I’m sure the error message is because we had cases of size_t for 32 bits and in the move to 64 bits this broke so we put in the error. Since size_t is not a distinct type this is really just going to generate an error for any 64 bit type on windows. These cases should be removed."