Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating promote and boost #98

Merged
merged 60 commits into from
Jun 20, 2023
Merged

Updating promote and boost #98

merged 60 commits into from
Jun 20, 2023

Conversation

sean-parent
Copy link
Member

@sean-parent sean-parent commented May 30, 2023 •
edited
Loading

Working on PR #96.

  • Removed the special case to diagnose Windows 64 vs. macOS 32-bit in convert.hpp
  • Unlike PR Update adobe::promote to use fixed width types and remove 64bit Win promote warning #96, this doesn't promote char types (the original did not). I'm afraid that would be a breaking change. I promoted all 16 & 32-bit arithmetic types to double to simplify maintenance (convert.hpp).
  • Fixed all unit tests on Windows (some sha tests are conditionalized because they contain strings that are too long).
  • Fixed the CI system (thanks to @camino)
  • Cleaned out several boost dependencies while waiting for CI.
  • Started working on better VSCode support.

@sean-parent sean-parent requested a review from camio May 30, 2023 03:31
@sean-parent sean-parent mentioned this pull request May 30, 2023
Closed
sean-parent and others added 27 commits June 1, 2023 18:55
@sean-parent
Updated code for C++17
6b30439 
- Updated code for C++17,
- Removed deprecated calls
- Fixed compiler warnings
- Removed support for compiling without thread_local variables
- Removed some unnecessary uses of boost
@sean-parent
Adding missing CI script and removing deprecated CI construct
a389ce3
@sean-parent
Trying legacy path for workflow.
6c3e2c5
@sean-parent
Updating execution bit for flatten_json.py
a32ffa9
@sean-parent
Update adobe_source_libraries.yml
0a337da
@sean-parent
Adding boost installs
0bb5bf3
@sean-parent
MacOS failed to find compiler - removing brew update and using latest…
99cab24 
… version
@sean-parent
Update adobe_source_libraries.yml
203dd77
@sean-parent
Update adobe_source_libraries.yml
055e583
@sean-parent
Trying to get windows build going and cleaning up cstdint while waiting.
0e77d24
@sean-parent
Another attempt on Windows...
21e2560
@sean-parent
Update CMakeLists.txt
95b01b3
@sean-parent
Update adobe_source_libraries.yml
cefe5b2
@sean-parent
Testing to see if this is still needed on windows.
fcaf925
@sean-parent
adding dependencies
fa2bb8b
@sean-parent
Update adobe_source_libraries.yml
c564530
@sean-parent
Update CMakeLists.txt
4635503
@sean-parent
Update CMakeLists.txt
a75e8ca
@sean-parent
Update adobe_source_libraries.yml
b0eff61
@sean-parent
99 tries to get Windows to build...
a35e035
@nickpdemarco
Attemmpt to fix CI by disabling unix-flavored compiler options.
dd58d68
@nickpdemarco
Cmake typo
aec1360
@sean-parent
More improvements.
2fe62c1
@sean-parent
Merge branch 'sean-parent/conversion' of https://github.com/stlab/ado…
178795e 
…be_source_libraries into sean-parent/conversion
@sean-parent
Removing warnings and fixing for windows.
049d51c
@sean-parent
More cleanup for windows
619097d
@sean-parent
Removing hack for testing - breaks windows build.
e64d06e
sean-parent and others added 27 commits June 6, 2023 21:37
@sean-parent
Update pmeval.cpp
e4ccbe1
@sean-parent
Updating windows compiler to fix long strings in test cases.
6c626a1
@sean-parent
Missing header.
0830227
@sean-parent
Windows build working locally
fec688c
@sean-parent
Patching to fix windows build in CI
a5cab5c
@sean-parent
Update adobe_source_libraries.yml
9e507e9
@sean-parent
Update adobe_source_libraries.yml
7c164f7
@sean-parent
Reverting to shorter dependency list, add flag to specify dyn linking…
90874d2 
… to test library.
@sean-parent
Attempt to convert setup to bash.
4c7a3b6
@sean-parent
Trying again with path forms converted.
ae8b529
@sean-parent
Trying without source
07d741c
@sean-parent
Update adobe_source_libraries.yml
f659da0
@sean-parent
Update CMakeLists.txt
dbf86b4
@dabrahams
Experiment to fix Windows build
27338f8
@sean-parent
Trying vcpkg versioning
1def5b3
@sean-parent
Update vcpkg.json
e1ae991
@sean-parent
Update vcpkg.json
31fe753
@sean-parent
Trying rolling version way back.
41aa725
@camio
Add missing vcvarsall.bat call to Windows CI workflow
b3b5689 
This script inserts environment variables that CMake needs to determine
compiler location.
@camio
Temporarily disable sha_shevs test
c192a9a 
Visual C++ 2022 abnormally exits when trying to compile this file,
presumably due to its size.
@camio
Remove cruft
7dbb55f
@camio
Set proper configuration for VS2022
8f21245
@sean-parent
Adding vscode preset for macOS
1ee13ba
@sean-parent
Merge remote-tracking branch 'origin/windows-CI-fix' into sean-parent…
979dda2 
…/conversion
@sean-parent
Cleanup
ded9643
@sean-parent
Merge branches 'sean-parent/conversion' and 'sean-parent/conversion' of
e03dde0 
https://github.com/stlab/adobe_source_libraries into sean-parent/conversion
@sean-parent
Final Cleanup?
4af46e1
@sean-parent sean-parent mentioned this pull request Jun 20, 2023
Closed
@sean-parent sean-parent merged commit fb2fc28 into master Jun 20, 2023
@sean-parent sean-parent deleted the sean-parent/conversion branch January 13, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camio camio Awaiting requested review from camio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sean-parent @nickpdemarco @dabrahams @camio