Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Extended support for STM32H7 & rework of software reset #1071

Merged
merged 19 commits into from
Dec 5, 2020
Merged

[feature] Extended support for STM32H7 & rework of software reset #1071

merged 19 commits into from
Dec 5, 2020

Conversation

Ant-ON
Copy link
Collaborator

@Ant-ON Ant-ON commented Nov 26, 2020

This fix improves MCU detection (specifically H7). Patch will add a check of the current MCU instructions mode and switch to thumb mode. In some cases, MCU may wrongly be in ARM instruction mode.
Optimizes MCU firmware via gdb. Adds automatic detection of cache presence and breakpoints style.

I checked this changes on the debug boards that I have (F0/F1/F3/G4). Also this branch was checked for H7 in #1059.

(Closes #532, Closes #801, Closes #1059, Closes #1063)
(Partially fixes #868, Partially fixes #1008)

@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Nov 28, 2020
@Nightwalker-87 Nightwalker-87 changed the title Improve H7 support [feature] Improved support for STM32H7 Nov 28, 2020
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@Nightwalker-87 Nightwalker-87 removed the request for review from timothytylee December 5, 2020 10:35
@Nightwalker-87 Nightwalker-87 merged commit b47f083 into stlink-org:develop Dec 5, 2020
@Nightwalker-87 Nightwalker-87 changed the title [feature] Improved support for STM32H7 Improved support for STM32H7 Dec 5, 2020
@Nightwalker-87 Nightwalker-87 changed the title Improved support for STM32H7 [feature] Extended support for STM32H7 Dec 5, 2020
@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Dec 5, 2020

@Ant-ON: Now, as our Travis CI is running again,
I found that this PR introduces some build failures when compiling with clang. Can you focus on that?
https://travis-ci.org/github/stlink-org/stlink/builds/747789017
Thanks in advance and sorry for the late feedback, we had no indication for that during review.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Dec 6, 2020

@Nightwalker-87 I saw a link to the problem in a nearby discussion. I will try to fix it as soon as possible. Will I need to make a new pull request?

@Nightwalker-87
Copy link
Member

Eh yes, as this one has been merged already, but you can continue on the used branch Ant-ON:try_h7_debug after pulling recent changes from our current develop branch to that personal feature branch. I'd propose to name the new PR "Extended support for STM32H7 (bugfix for clang)" and we shall be fine. I'll wait with any further contributions until you submitted a working patch. :-)

@stlink-org stlink-org locked as resolved and limited conversation to collaborators Mar 20, 2021
@Nightwalker-87 Nightwalker-87 linked an issue Mar 24, 2021 that may be closed by this pull request
@Nightwalker-87 Nightwalker-87 changed the title [feature] Extended support for STM32H7 [feature] Extended support for STM32H7 & rework of software reset Mar 24, 2021
@Nightwalker-87 Nightwalker-87 linked an issue Apr 4, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.