-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactoring] Optimisation for processing chipid files #1234
[refactoring] Optimisation for processing chipid files #1234
Conversation
'moved chip dump to stdout instead of stderr' 'closing open fd after file is fully read' 'reduced file read buffer size'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sylensky, thanks for your contribution. I’ve left a few comments in the changes.
I’m sorry for the delay, I hope I’ll be able to review this PR next week. |
Yes, there is nothing else I can report from my side actually... 😔 |
Well, no luck, I won’t have enough time. Just one more thing I’ve spotted: the new small buffer size may cause issues on lines having long comments. |
I thought about that aswell. Making it double should totally be enough. Or do you see a case where such long comments might still be useful? |
I’m not sure about its usefulness, but FWIW here stlink/config/chips/F76x_F77x.chip Line 12 in 8d96e76
|
I checked the other files and the |
Hi everyone,
during my work i made some changes to the stlink library which i thought of would benefit the overall project.
These changes include optimizations in the processing of chipfiles and in a seperate PR the addition of option byte descriptions.