Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compilation] Corrected path to stlink/chips subdirectory #1279

Merged
merged 3 commits into from
Dec 18, 2022

Conversation

weiminshen99
Copy link
Contributor

@weiminshen99 weiminshen99 commented Nov 14, 2022

Fixes Issue #1276.

Copy link
Member

@Nightwalker-87 Nightwalker-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the standard directory for installations on unix-based systems.
You may add an if-clause for identifying macOS systems instead.

@weiminshen99
Copy link
Contributor Author

Hi, I have added the if-clause for macOS as you suggested. Please review again. Thanks.

@Nightwalker-87 Nightwalker-87 added this to the v1.7.1 milestone Dec 3, 2022
@Nightwalker-87 Nightwalker-87 linked an issue Dec 18, 2022 that may be closed by this pull request
6 tasks
@Nightwalker-87 Nightwalker-87 changed the title Fix Issue #1276. [compilation]: Correct path to stlink/chips subdirectory Dec 18, 2022
@Nightwalker-87 Nightwalker-87 changed the title [compilation]: Correct path to stlink/chips subdirectory [compilation] Correct path to stlink/chips subdirectory Dec 18, 2022
@Nightwalker-87 Nightwalker-87 changed the title [compilation] Correct path to stlink/chips subdirectory [compilation] Corrected path to stlink/chips subdirectory Dec 18, 2022
@Nightwalker-87 Nightwalker-87 merged commit 879e769 into stlink-org:develop Dec 18, 2022
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[compilation] Correct path to stlink/chips subdirectory
2 participants