Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Version.cmake more error-resistant / Fixed sign-compare (size != rep_len) in usb.c (Fixes #772) #872

Merged
merged 11 commits into from
Mar 21, 2020

Conversation

slyshykO
Copy link
Collaborator

@slyshykO slyshykO commented Mar 1, 2020

No description provided.

WRR and others added 10 commits August 12, 2019 11:37
# Conflicts:
#	include/stlink/chipid.h
#	src/chipid.c
* add mingw64 build to travis CI

* Make .travis-lin-mingw.sh executable

* .travis-lin-mingw.sh: make build dir

* show $PWD in travis-lin-mingw

* update .travis-lin-mingw.sh

* ---

* update .travis-lin-mingw.sh

* update p7zip cmd

* fix sign/unsign comparioson in usb.c

* revert call .travis.sh

* clean up .travis-lin-mingw.sh
@Nightwalker-87 Nightwalker-87 added this to the v1.6.1 milestone Mar 1, 2020
@Nightwalker-87 Nightwalker-87 linked an issue Mar 11, 2020 that may be closed by this pull request
2 tasks
@Nightwalker-87
Copy link
Member

Info: Merge is still awaiting second review and end of travis CI maintenance window. Services are still limited. :-/

Copy link
Member

@Nightwalker-87 Nightwalker-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping second reviewer then to get this done...
I think you have been waiting long enough for this...

@Nightwalker-87 Nightwalker-87 removed the request for review from bmarvo March 21, 2020 19:35
@Nightwalker-87
Copy link
Member

This travis CI for macOS gets on my nerves right now... (╯°□°)╯︵ ┻━┻
We need to wait again, backlog and traffic is too high...

@Nightwalker-87 Nightwalker-87 changed the title make Version.cmake more error-resistant. fix #772 make Version.cmake more error-resistant (Fixes #772) Mar 21, 2020
@Nightwalker-87 Nightwalker-87 merged commit 677a3be into stlink-org:develop Mar 21, 2020
@Nightwalker-87
Copy link
Member

@slyshykO: Hooray! Finally got it through after endless attempts in travis... Thank you so much for your patience and of course for your contribution!

@slyshykO slyshykO deleted the detect-version branch March 21, 2020 20:52
@Nightwalker-87 Nightwalker-87 linked an issue Mar 21, 2020 that may be closed by this pull request
@Nightwalker-87 Nightwalker-87 mentioned this pull request Mar 21, 2020
@Nightwalker-87 Nightwalker-87 linked an issue Mar 21, 2020 that may be closed by this pull request
@Nightwalker-87 Nightwalker-87 changed the title make Version.cmake more error-resistant (Fixes #772) Make Version.cmake more error-resistant / Fixed sign-compare (size != rep_len) in usb.c (Fixes #772) Mar 21, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Build fails Compilation error on raspbian
2 participants