Allow pin modes OpenDrain and PushPull for SPI output pins #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
requested changes
Mar 30, 2023
There was a problem hiding this comment.
Thanks for the PR! Changes look good, and according to ST AN4899 section 4.3.3:
The output buffer can be configured in open-drain or push-pull mode
This is a supported feature so we're all good.
Can you please add a changelog entry under the Additions heading?
Clippy is also whinging in CI but that looks like an easy fix. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to use
OpenDrainmode for SPI output pins, but the init for SPI were only defined for pins set toAnalog(i.e. implicitlyPushPull). Therefore I addedOutput<OpenDrain>as an alternative and alsoOutput<PushPull>to allow for more explicit user peripheral setup code.