Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(StoneDB 8.0) : duplicate 'lc-messages-dir' config item in my.cnf.sample file #688

Closed
2 of 3 tasks
lujiashun opened this issue Oct 11, 2022 · 3 comments · Fixed by #869
Closed
2 of 3 tasks

bug(StoneDB 8.0) : duplicate 'lc-messages-dir' config item in my.cnf.sample file #688

lujiashun opened this issue Oct 11, 2022 · 3 comments · Fixed by #869
Assignees
Labels
A-bug Something isn't working C-stonedb-8.0 associated with stonedb 8.0 good first issue Good for newcomers

Comments

@lujiashun
Copy link

lujiashun commented Oct 11, 2022

Have you read the Contributing Guidelines on issues?

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the problem

in branch StoneDB-8.0-dev, my.cnf.sample in ./scripts directory.
there are two 'lc-messages-dir' config items.

port                            = 3306
basedir                         = YOUR_ABS_PATH/
character-sets-dir              = YOUR_ABS_PATH/share/charsets/
lc-messages-dir                 = YOUR_ABS_PATH/share/
plugin_dir                      = YOUR_ABS_PATH/lib/plugin/
tmpdir                          = YOUR_ABS_PATH/tmp/
socket                          = YOUR_ABS_PATH/tmp/mysql.sock
datadir                         = YOUR_ABS_PATH/data/
pid-file                        = YOUR_ABS_PATH/data/mysqld.pid
log-error                       = YOUR_ABS_PATH/log/mysqld.log
lc-messages-dir                 = YOUR_ABS_PATH/share/english/

Expected behavior

Just one 'lc-messages-dir'.

How To Reproduce

No response

Environment

No response

Are you interested in submitting a PR to solve the problem?

  • Yes, I will!
@lujiashun lujiashun added A-bug Something isn't working good first issue Good for newcomers C-stonedb-8.0 associated with stonedb 8.0 labels Oct 11, 2022
@RingsC
Copy link
Contributor

RingsC commented Oct 11, 2022

adds a params : "lc_messages" to my.cnf.

@lujiashun lujiashun changed the title bug(StoneDB 8.0) : duplicate 'lc-messages-dir' config item in my.cnf.sample bug(StoneDB 8.0) : duplicate 'lc-messages-dir' config item in my.cnf.sample file Oct 11, 2022
@hustjieke hustjieke added this to the stonedb_8.0_v1.0.0 milestone Oct 12, 2022
@hustjieke
Copy link
Collaborator

Impact both on branch 5.7 and 8.0.

@lujiashun
Copy link
Author

ACK

lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Nov 1, 2022
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Nov 1, 2022
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Nov 1, 2022
@mergify mergify bot closed this as completed in #869 Nov 1, 2022
mergify bot pushed a commit that referenced this issue Nov 1, 2022
Repository owner moved this from Todo to Done in StoneDB for MySQL 8.0 Nov 1, 2022
mergify bot pushed a commit that referenced this issue Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bug Something isn't working C-stonedb-8.0 associated with stonedb 8.0 good first issue Good for newcomers
Projects
3 participants