Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tianmu): fix duplicate 'lc-messages-dir' config item in my.cnf.sample file. (#688) #869

Merged
merged 2 commits into from
Nov 1, 2022
Merged

fix(tianmu): fix duplicate 'lc-messages-dir' config item in my.cnf.sample file. (#688) #869

merged 2 commits into from
Nov 1, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Nov 1, 2022 •
edited
Loading

Summary about this PR

Issue Number: close #688

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@lujiashun lujiashun self-assigned this Nov 1, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Nov 1, 2022
@lujiashun lujiashun changed the title fix(tianmu): fix duplicate 'lc-messages-dir' config item in my.cnf.sa… fix(tianmu): fix duplicate 'lc-messages-dir' config item in my.cnf.sample file. (#688) Nov 1, 2022
hustjieke
hustjieke approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DandreChen
DandreChen approved these changes Nov 1, 2022
View reviewed changes
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 5e86e93 into stoneatom:stonedb-5.7-dev Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isredstar isredstar isredstar approved these changes

@DandreChen DandreChen DandreChen approved these changes

@hustjieke hustjieke hustjieke approved these changes

@RingsC RingsC RingsC approved these changes

Assignees

@lujiashun lujiashun

Labels
PR-bug bug for pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(StoneDB 8.0) : duplicate 'lc-messages-dir' config item in my.cnf.sample file
5 participants
@lujiashun @RingsC @hustjieke @DandreChen @isredstar