Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: formate code with clang-format #7

Closed
hustjieke opened this issue Jun 15, 2022 · 0 comments
Closed

feature: formate code with clang-format #7

hustjieke opened this issue Jun 15, 2022 · 0 comments
Assignees
@hustjieke
Labels
A-feature feature with good idea prio: high High priority
Milestone
StoneDB_5.6_v1.0.0

Comments

@hustjieke
Copy link
Collaborator

hustjieke commented Jun 15, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Formate code with clang-formt.
guides by: https://google.github.io/styleguide/

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@hustjieke hustjieke added the A-feature feature with good idea label Jun 15, 2022
@hustjieke hustjieke self-assigned this Jun 15, 2022
@hustjieke hustjieke changed the title feature: backport code from local repo feature: formate code with clang-format Jun 15, 2022
RingsC pushed a commit that referenced this issue Jun 16, 2022
@hustjieke @RingsC
feat(stonedb): formate code with clang-format (#7)
cfa7101
@hustjieke hustjieke added this to the v0.1 milestone Jun 16, 2022
@hustjieke hustjieke added the prio: high High priority label Jun 17, 2022
This was referenced Jul 13, 2022
Closed
Closed
@adofsauron adofsauron mentioned this issue Aug 3, 2022
Closed
xiaoguangye referenced this issue in xiaoguangye/stonedb Aug 5, 2022
@xiaoguangye @mergify
# This is a combination of 8 commits.
2f07bb2 
# This is the 1st commit message:

rich doc to fix  env dependence "not found" (stoneatom#316)


# This is the commit message #2:

fix(mtr): make the mtr passed (stoneatom#315) (stoneatom#317)

[summary]
How to run:
./mysql-test-run.pl --suite=stonedb --nowarnings --force --nocheck-testcases

1. test cases below are failed, we ignored them first:
issue410
issue415
issue433
issue446
issue515
load.test
2. Sys variables next are not set correctly, they should be added to `/mysql-test/include/default_mysqld.cnf`.
stonedb_insert_delayed = 0
stonedb_ini_allowmysqlquerypath=1

3.check-testcases: A new MTR option to enforce strict cleanup:
https://dev.mysql.com/blog-archive/fail-check-testcases-a-new-mtr-option-to-enforce-strict-cleanup

In `mtr` comment:
```
Some options that control enabling a feature for normal test runs,
can be turned off by prepending 'no' to the option, e.g. --notimer.
This applies to reorder, timer, check-testcases and warnings.
```
Currently we turn off it first to make mtr run success.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #3:

feat(stonedb): update the copyright date time (stoneatom#321) (stoneatom#324)


# This is the commit message #4:

fix(core): fix crash when executing sql. (stoneatom#327) (stoneatom#328)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #5:

feat(index): Unified class member variable name with google style (stoneatom#311) (stoneatom#312)

[summary]
Class member name will be like:

class TableInfo {
  ...
 private:
  std::string table_name_;  // OK - underscore at end.
  static Pool<TableInfo>* pool_;  // OK.
};

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #6:

fix(mtr):move character_set to test.character_set, fix main mtr_test and innodb mtr_test(stoneatom#277) (stoneatom#335)

* fix(mtr):fix innodb mtr and mv some test to test/innodb

* fix(mtr):move character_set to test/main/

fix(mtr):mv main mtr character_set test to test/main/cahracter_set

fix(mtr):mv myisam error mtr-test to test/main/myisam

fix(mtr):add optimizer_switch to include/default_mysqld.cnf

* fix(mtr):fix main mtr optimizer_switch amd mv some test to test/main

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #7:

feat(tianmu): stonedb namespace to tianmu (stoneatom#337)

[summary]
1. Change all engine stonedb to tianmu
2. Change SDB to tianmu
3. Also include mysql-test
4. Change file magic number to TianmuTB
# This is the commit message stoneatom#8:

fix bugs of stoneatom#309 and stoneatom#310 (stoneatom#313)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
xiaoguangye referenced this issue in xiaoguangye/stonedb Aug 10, 2022
@xiaoguangye @mergify
# This is a combination of 7 commits.
5fe392e 
# This is the 1st commit message:

fix(core): Double prepare on lex unit for cts with union(stoneatom#226)

fix(core): MTR + Double prepare on lex unit for ctas with union(stoneatom#226)

# This is the commit message #2:

rich doc to fix  env dependence "not found" (stoneatom#316)


# This is the commit message #3:

fix(mtr): make the mtr passed (stoneatom#315) (stoneatom#317)

[summary]
How to run:
./mysql-test-run.pl --suite=stonedb --nowarnings --force --nocheck-testcases

1. test cases below are failed, we ignored them first:
issue410
issue415
issue433
issue446
issue515
load.test
2. Sys variables next are not set correctly, they should be added to `/mysql-test/include/default_mysqld.cnf`.
stonedb_insert_delayed = 0
stonedb_ini_allowmysqlquerypath=1

3.check-testcases: A new MTR option to enforce strict cleanup:
https://dev.mysql.com/blog-archive/fail-check-testcases-a-new-mtr-option-to-enforce-strict-cleanup

In `mtr` comment:
```
Some options that control enabling a feature for normal test runs,
can be turned off by prepending 'no' to the option, e.g. --notimer.
This applies to reorder, timer, check-testcases and warnings.
```
Currently we turn off it first to make mtr run success.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #4:

feat(stonedb): update the copyright date time (stoneatom#321) (stoneatom#324)


# This is the commit message #5:

fix(core): fix crash when executing sql. (stoneatom#327) (stoneatom#328)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #6:

feat(index): Unified class member variable name with google style (stoneatom#311) (stoneatom#312)

[summary]
Class member name will be like:

class TableInfo {
  ...
 private:
  std::string table_name_;  // OK - underscore at end.
  static Pool<TableInfo>* pool_;  // OK.
};

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #7:

fix(mtr):move character_set to test.character_set, fix main mtr_test and innodb mtr_test(stoneatom#277) (stoneatom#335)

* fix(mtr):fix innodb mtr and mv some test to test/innodb

* fix(mtr):move character_set to test/main/

fix(mtr):mv main mtr character_set test to test/main/cahracter_set

fix(mtr):mv myisam error mtr-test to test/main/myisam

fix(mtr):add optimizer_switch to include/default_mysqld.cnf

* fix(mtr):fix main mtr optimizer_switch amd mv some test to test/main

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
xiaoguangye referenced this issue in xiaoguangye/stonedb Aug 11, 2022
@xiaoguangye @mergify
# This is a combination of 7 commits.
d8ec22b 
# This is the 1st commit message:

fix(core): Double prepare on lex unit for cts with union(stoneatom#226)

fix(core): MTR + Double prepare on lex unit for ctas with union(stoneatom#226)

# This is the commit message #2:

rich doc to fix  env dependence "not found" (stoneatom#316)


# This is the commit message #3:

fix(mtr): make the mtr passed (stoneatom#315) (stoneatom#317)

[summary]
How to run:
./mysql-test-run.pl --suite=stonedb --nowarnings --force --nocheck-testcases

1. test cases below are failed, we ignored them first:
issue410
issue415
issue433
issue446
issue515
load.test
2. Sys variables next are not set correctly, they should be added to `/mysql-test/include/default_mysqld.cnf`.
stonedb_insert_delayed = 0
stonedb_ini_allowmysqlquerypath=1

3.check-testcases: A new MTR option to enforce strict cleanup:
https://dev.mysql.com/blog-archive/fail-check-testcases-a-new-mtr-option-to-enforce-strict-cleanup

In `mtr` comment:
```
Some options that control enabling a feature for normal test runs,
can be turned off by prepending 'no' to the option, e.g. --notimer.
This applies to reorder, timer, check-testcases and warnings.
```
Currently we turn off it first to make mtr run success.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #4:

feat(stonedb): update the copyright date time (stoneatom#321) (stoneatom#324)


# This is the commit message #5:

fix(core): fix crash when executing sql. (stoneatom#327) (stoneatom#328)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #6:

feat(index): Unified class member variable name with google style (stoneatom#311) (stoneatom#312)

[summary]
Class member name will be like:

class TableInfo {
  ...
 private:
  std::string table_name_;  // OK - underscore at end.
  static Pool<TableInfo>* pool_;  // OK.
};

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #7:

fix(mtr):move character_set to test.character_set, fix main mtr_test and innodb mtr_test(stoneatom#277) (stoneatom#335)

* fix(mtr):fix innodb mtr and mv some test to test/innodb

* fix(mtr):move character_set to test/main/

fix(mtr):mv main mtr character_set test to test/main/cahracter_set

fix(mtr):mv myisam error mtr-test to test/main/myisam

fix(mtr):add optimizer_switch to include/default_mysqld.cnf

* fix(mtr):fix main mtr optimizer_switch amd mv some test to test/main

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@adofsauron adofsauron mentioned this issue Aug 16, 2022
Closed
1 task
@adofsauron adofsauron mentioned this issue Sep 13, 2022
Closed
1 task
@adofsauron adofsauron mentioned this issue Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hustjieke hustjieke

Labels
A-feature feature with good idea prio: high High priority
Projects
None yet
Milestone
StoneDB_5.6_v1.0.0
Development

No branches or pull requests
1 participant
@hustjieke