-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stonedb): formate code with clang-format (#7) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustjieke
changed the title
feat(stonedb): port code from local stonedb (#7)
feat(stonedb): formate code with clang-format (#7)
Jun 16, 2022
RingsC
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jul 13, 2022
xiaoguangye
added a commit
to xiaoguangye/stonedb
that referenced
this pull request
Aug 5, 2022
# This is the 1st commit message: rich doc to fix env dependence "not found" (stoneatom#316) # This is the commit message #2: fix(mtr): make the mtr passed (stoneatom#315) (stoneatom#317) [summary] How to run: ./mysql-test-run.pl --suite=stonedb --nowarnings --force --nocheck-testcases 1. test cases below are failed, we ignored them first: issue410 issue415 issue433 issue446 issue515 load.test 2. Sys variables next are not set correctly, they should be added to `/mysql-test/include/default_mysqld.cnf`. stonedb_insert_delayed = 0 stonedb_ini_allowmysqlquerypath=1 3.check-testcases: A new MTR option to enforce strict cleanup: https://dev.mysql.com/blog-archive/fail-check-testcases-a-new-mtr-option-to-enforce-strict-cleanup In `mtr` comment: ``` Some options that control enabling a feature for normal test runs, can be turned off by prepending 'no' to the option, e.g. --notimer. This applies to reorder, timer, check-testcases and warnings. ``` Currently we turn off it first to make mtr run success. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> # This is the commit message #3: feat(stonedb): update the copyright date time (stoneatom#321) (stoneatom#324) # This is the commit message #4: fix(core): fix crash when executing sql. (stoneatom#327) (stoneatom#328) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> # This is the commit message #5: feat(index): Unified class member variable name with google style (stoneatom#311) (stoneatom#312) [summary] Class member name will be like: class TableInfo { ... private: std::string table_name_; // OK - underscore at end. static Pool<TableInfo>* pool_; // OK. }; Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> # This is the commit message #6: fix(mtr):move character_set to test.character_set, fix main mtr_test and innodb mtr_test(stoneatom#277) (stoneatom#335) * fix(mtr):fix innodb mtr and mv some test to test/innodb * fix(mtr):move character_set to test/main/ fix(mtr):mv main mtr character_set test to test/main/cahracter_set fix(mtr):mv myisam error mtr-test to test/main/myisam fix(mtr):add optimizer_switch to include/default_mysqld.cnf * fix(mtr):fix main mtr optimizer_switch amd mv some test to test/main Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> # This is the commit message #7: feat(tianmu): stonedb namespace to tianmu (stoneatom#337) [summary] 1. Change all engine stonedb to tianmu 2. Change SDB to tianmu 3. Also include mysql-test 4. Change file magic number to TianmuTB # This is the commit message stoneatom#8: fix bugs of stoneatom#309 and stoneatom#310 (stoneatom#313) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 task
1 task
Thanks for the contribution! Please review the labels and make any necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Formate code.
Changelog