Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stonedb):unsupport DDL should report error in SQL layer and ignore error in BINLOG layer.(#1227) #1270

Merged

Conversation

DandreChen
Copy link
Collaborator

@DandreChen DandreChen commented Feb 2, 2023

Summary about this PR

Issue Number: close #1227
[summary]
in sql layer:
1 secondary/unique index report error;
2 full text/SPTIAL report error;
3 partition/foreign key report error;
4 GEOMETRY/SET/ENUM data type report error;
5 create trigger report error;

in binlog layer:
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…eatom#1185)

[summary]
1 secondary/unique index report error;
2 full text/SPTIAL report error;
3 partition/foreign key report error;
4 GEOMETRY/SET/ENUM data type report error;
5 create trigger report error;
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Feb 2, 2023
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…neatom#1186)

Add test case for filtering errors.
Filter the errors of secondary index、unique index、fulltext index、trigger、 foreign key in binlog layer.
@DandreChen DandreChen force-pushed the feat_filter_ddl_on_binlog_events branch from 16b1e8b to 82bc9e6 Compare February 2, 2023 14:55
@mergify mergify bot merged commit bf5e98a into stoneatom:stonedb-5.7-dev Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: unsupport DDL should report error in SQL layer and ignore error in BINLOG layer
3 participants