feat(StoneDB 8.0): st_select_lex::set_join is deleted in mysql8.0. (#598) #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #598
1 in the commit(commit1) below, st_select_lex::set_join is renamed as SELECT_LEX::set_join
mysql/mysql-server@74f720b
2 in the commit(commit2) below, SELECT_LEX::set_join is deleted:
mysql/mysql-server@03b579f
3 in commit2, it is given the reference to implement the set_join:
set_join(join_local);
4 by the way, comment of variable Query_block::join is like this:
5 So, use LOCK_query_plan mutex to implement set_join is a proper way.
Tests Check List
Changelog
Documentation