Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StoneDB 8.0): st_select_lex::set_join is deleted in mysql8.0. (#598) #602

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

lujiashun
Copy link

Summary about this PR

Issue Number: close #598

1 in the commit(commit1) below, st_select_lex::set_join is renamed as SELECT_LEX::set_join
mysql/mysql-server@74f720b
2 in the commit(commit2) below, SELECT_LEX::set_join is deleted:
mysql/mysql-server@03b579f
3 in commit2, it is given the reference to implement the set_join:

old version new version
set_join(join_local); 
  thd->lock_query_plan();
  join = join_local;
  thd->unlock_query_plan();

4 by the way, comment of variable Query_block::join is like this:

  /**
    After optimization it is pointer to corresponding JOIN. This member
    should be changed only when THD::LOCK_query_plan mutex is taken.
  */
  JOIN *join{nullptr};

5 So, use LOCK_query_plan mutex to implement set_join is a proper way.

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…toneatom#598)

[summary]
1 take THD::LOCK_query_plan mutex to change the join value;
@lujiashun lujiashun added the C-stonedb-8.0 associated with stonedb 8.0 label Sep 28, 2022
@lujiashun lujiashun added this to the stonedb_8.0_v1.0.0 milestone Sep 28, 2022
@lujiashun lujiashun self-assigned this Sep 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 28, 2022
Copy link
Collaborator

@DandreChen DandreChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Sep 28, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot merged commit da4752b into stoneatom:stonedb-8.0-dev Sep 28, 2022
@lujiashun lujiashun deleted the feat-598 branch September 29, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-stonedb-8.0 associated with stonedb 8.0 PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants