Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move access-api delegation bytes out of d1 and into r2 #578
feat: move access-api delegation bytes out of d1 and into r2 #578
Changes from 17 commits
1e83d67
198e32d
963a0d4
e957d94
83c9c49
e65dd19
b491acb
000c704
044f76b
eeab7fd
a39b780
bd42ee4
568d095
0186d6a
9fce623
51e2835
8acaa8d
ecbe77d
c77d0cd
37b05c1
7f616d8
6fa5390
fe26c70
e379699
7d017e7
e2da517
3261215
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have a bucket specific to the things it's storing? We can create many of these - we don't have to have only 1 for everything we store.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think @alanshaw suggesting this should be more like
DELEGATIONS_BUCKET
which I'd find to be more intuitive as well. I would also suggest not baking product names likeR2
so it's not tied to CF product and could work e.g if we move to S3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#603
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Would be nice if error said wrangler magic one supposed to do to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shouldn't happen under normal circumstances, i.e. there is no wrangler magic to recommend. the
wranger.toml
will set this up in a good way for known envs. This would catch it if you somehow opted out of that calling this function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you avoid changing this unless needed as it would create conflict with my PR also changing this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #578 (comment)