success (and error) callbacks from database.close are never called

[Typhlosaurus]

in unit tests for our application we close, delete and then re-open the database before each test. As coded the actual database close is performed asynchronously but the confirmation callback is never called making database swapout unreliable.

Worse, in the android implementation this together with #112 mean that when a subsequent openDatabase() call is made for the same name, a new thread is started which can overlap with the old thread for the same database.

[nolanlawson]

Would love a unit test and a fix for the Java code. :) Should be a one-liner for Android at least.

[Typhlosaurus]

Ok - will do.

[brodycj]

After applying the changes to SQLitePlugin.coffee.md from the master branch of the @Typhlosaurus fork to the common-src branch of this project (and regenerating the Javascript), there is one failure on the iOS version in the close then re-open allows subsequent queries to run test. All of the other new tests from the master branch of the @Typhlosaurus fork are now passing on the iOS version. Some very nice work!

[Typhlosaurus]

Thanks.

On 21 August 2014 01:13, Chris Brody notifications@github.com wrote:

After applying the changes to SQLitePlugin.coffee.md from the master
branch of the @Typhlosaurus https://github.com/Typhlosaurus fork to the
common-src branch of this project (and regenerating the Javascript),
there is one failure on the iOS version in the close then re-open allows
subsequent queries to run test. All of the other new tests from the master
branch of the @Typhlosaurus https://github.com/Typhlosaurus fork are
now passing on the iOS version. Some very nice work!

—
Reply to this email directly or view it on GitHub
#109 (comment)
.

[brodycj]

Now fixed inmaster (version 1.0.1)