database.executeSql calls its success callback twice

[Typhlosaurus]

The database.executeSql method is implemented in SQLitePlugin.js by passing the provided success and error callbacks both to the sql statement execution and to the transaction. This means that on successful execution the success callback is called first as

callback(transaction, results);

then as:

callback();

On a failure, depending on the nature of the error, either the success then error callbacks will be called or the error callback will be called twice.

These oddities can be avoided by using an explicit transaction and transaction.executeSql.

[nolanlawson]

This sounds like a pretty bad bug. Can you write a unit test to reproduce? Our tests are here and there are instructions in the README for executing them.

[Typhlosaurus]

OK.

[brodycj]

This sounds like a pretty bad bug. Can you write a unit test to reproduce?
Our tests are here
https://github.com/brodysoft/Cordova-SQLitePlugin/blob/master/test-www/www/index.html
and there are instructions in the README for executing them.

My idea is to add a unit test that checks that the [first] received
callback does not include the transaction argument. I am happy to take
this one.

Chris

[brodycj]

Guys, I would like to apply the changes that I have proposed in #117 pretty soon, before submitting to the PhoneGap build. It is basically a one-liner CoffeeScript/JavaScript change. I have only tested it on iOS so far but am absolutely confident it will work for all platforms. Any objections?

[nolanlawson]

I can test it on android 2.3 and 4.4 tonight.

[brodycj]

I would like to thank you guys both @Typhlosaurus and @nolanlawson for your help on this. @Typhlosaurus we are both very thankful to you that you have identified this bug for us.

I have decided to include a much simpler solution in the interest of timing.

I will use your work to reproduce the other issues in the next few weeks. Thanks again!

[MuhammadImran-04]

I'm still facing this issue on android. The Plugin version I'm using is: "0.7.15-dev", and cordova version is 5.3.3. Can anyone help?

[brodycj]

I'm still facing this issue on android. The Plugin version I'm using is: "0.7.15-dev", and cordova version is 5.3.3. Can anyone help?

Unfortunately that is not enough information. Can you demonstrate this with a test program?