Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cra): remove ts docgen loader #103

Merged
merged 5 commits into from
Mar 6, 2020
Merged

feat(cra): remove ts docgen loader #103

merged 5 commits into from
Mar 6, 2020

Conversation

mrmckeb
Copy link
Member

@mrmckeb mrmckeb commented Feb 19, 2020 •
edited
Loading

This PR doe the following:

  • Dependency bump
  • Adds GitHub Actions for CI with matrix testing (Mac, Linux, Windows against Node 10, 12)
  • Removes CircleCI (the GitHub implementation covers more)
  • Removes the dirty-repo-check as this isn't needed when using yarn --frozen-lockfile when the environment variable CI is set to true.
  • Removes the TS Docgen Loader for the preset.

@mrmckeb mrmckeb requested a review from shilman February 19, 2020 08:45
@mrmckeb mrmckeb self-assigned this Feb 19, 2020
graup added a commit to graup/presets that referenced this pull request Feb 28, 2020
@graup
Improve compat of preset-typescript with Vue
05a0aa5 
- remove ts docgen loader (rollup storybookjs#103)
- don't default to empty include option (rollup storybookjs#106)
- add appendTsSuffixTo to tsLoader options if framework is vue
@graup graup mentioned this pull request Feb 28, 2020
Merged
@mrmckeb mrmckeb marked this pull request as ready for review March 1, 2020 15:35
@mrmckeb mrmckeb mentioned this pull request Mar 2, 2020
Merged
@shilman
Copy link
Member

shilman commented Mar 4, 2020

@mrmckeb i'm getting the following when testing examples/cra-ts in this branch:

MDX___Button_-_Button_⋅_Storybook

Button_-_Default_⋅_Storybook

am i missing something?

@mrmckeb mrmckeb force-pushed the feature/remove-ts-docgen branch 2 times, most recently from 2d29a8f to a2d59c5 Compare March 6, 2020 10:22
@shilman shilman merged commit 51ce898 into master Mar 6, 2020
@shilman shilman deleted the feature/remove-ts-docgen branch March 6, 2020 10:32
@shilman shilman mentioned this pull request Mar 6, 2020
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

Assignees

@mrmckeb mrmckeb

Labels
create-react-app documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmckeb @shilman