fix(preset-typescript): don't default to empty include option #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graup
added a commit
to graup/presets
that referenced
this pull request
Feb 28, 2020
- remove ts docgen loader (rollup storybookjs#103) - don't default to empty include option (rollup storybookjs#106) - add appendTsSuffixTo to tsLoader options if framework is vue
graup
added a commit
to graup/presets
that referenced
this pull request
Feb 28, 2020
- Remove `react-typescript-docgen-loader` from `preset-typescript` (rollup storybookjs#68) - Don't default to empty include option (rollup storybookjs#106) - Add appendTsSuffixTo to tsLoader options if framework is vue
This was referenced Mar 5, 2020
graup
added a commit
to graup/presets
that referenced
this pull request
Mar 5, 2020
- Remove `react-typescript-docgen-loader` from `preset-typescript` (rollup storybookjs#68) - Don't default to empty include option (rollup storybookjs#106) - Add appendTsSuffixTo to tsLoader options if framework is vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #73 the
includeoption for the typescript loader defaults to an empty array, which essentially makes it required ([]never matches). This PR only addsincludeto the loader if something was provided in the addons config.Alternative approach: clarify in readme that
includeis not an advanced option but required.