Merge pull request #25993 from storybookjs/tom/drop-unneeded-set-args

Core: Drop unneeded `UPDATE_STORY_ARGS` which was there for SSv6 and back-compat.

code/lib/preview-api/src/modules/preview-web/PreviewWeb.test.ts

@@ -208,15 +208,19 @@ describe('PreviewWeb', () => {
         one: 1,
       });
     });
-    it('updates args from the URL', async () => {
+
+    it('prepares story with args from the URL', async () => {
       document.location.search = '?id=component-one--a&args=foo:url';
 
       await createAndRenderPreview();
 
-      expect(mockChannel.emit).toHaveBeenCalledWith(STORY_ARGS_UPDATED, {
-        storyId: 'component-one--a',
-        args: { foo: 'url', one: 1 },
-      });
+      expect(mockChannel.emit).toHaveBeenCalledWith(
+        STORY_PREPARED,
+        expect.objectContaining({
+          id: 'component-one--a',
+          args: { foo: 'url', one: 1 },
+        })
+      );
     });
 
     it('allows async getProjectAnnotations', async () => {
@@ -2798,20 +2802,6 @@ describe('PreviewWeb', () => {
         });
       });
 
-      it('emits STORY_ARGS_UPDATED with new args', async () => {
-        document.location.search = '?id=component-one--a';
-        const preview = await createAndRenderPreview();
-        mockChannel.emit.mockClear();
-
-        preview.onStoriesChanged({ importFn: newImportFn });
-        await waitForRender();
-
-        expect(mockChannel.emit).toHaveBeenCalledWith(STORY_ARGS_UPDATED, {
-          storyId: 'component-one--a',
-          args: { foo: 'edited', one: 1 },
-        });
-      });
-
       it('applies loaders with story context', async () => {
         document.location.search = '?id=component-one--a';
         const preview = await createAndRenderPreview();
@@ -3402,18 +3392,21 @@ describe('PreviewWeb', () => {
       });
     });
 
-    it('emits SET_STORY_ARGS with new values', async () => {
+    it('emits SET_PREPARED with new args', async () => {
       document.location.search = '?id=component-one--a';
       const preview = await createAndRenderPreview();
 
       mockChannel.emit.mockClear();
       preview.onGetProjectAnnotationsChanged({ getProjectAnnotations: newGetProjectAnnotations });
       await waitForRender();
 
-      expect(mockChannel.emit).toHaveBeenCalledWith(STORY_ARGS_UPDATED, {
-        storyId: 'component-one--a',
-        args: { foo: 'a', one: 1, global: 'added' },
-      });
+      expect(mockChannel.emit).toHaveBeenCalledWith(
+        STORY_PREPARED,
+        expect.objectContaining({
+          id: 'component-one--a',
+          args: { foo: 'a', one: 1, global: 'added' },
+        })
+      );
     });
 
     it('calls renderToCanvas teardown', async () => {

code/lib/preview-api/src/modules/preview-web/PreviewWithSelection.tsx

@@ -5,7 +5,6 @@ import {
   PRELOAD_ENTRIES,
   PREVIEW_KEYDOWN,
   SET_CURRENT_STORY,
-  STORY_ARGS_UPDATED,
   STORY_CHANGED,
   STORY_ERRORED,
   STORY_MISSING,
@@ -404,13 +403,6 @@ export class PreviewWithSelection<TRenderer extends Renderer> extends Preview<TR
         argTypes,
         args: unmappedArgs,
       });
-
-      // For v6 mode / compatibility
-      // If the implementation changed, or args were persisted, the args may have changed,
-      // and the STORY_PREPARED event above may not be respected.
-      if (implementationChanged || persistedArgs) {
-        this.channel.emit(STORY_ARGS_UPDATED, { storyId, args: unmappedArgs });
-      }
     } else {
       // Default to the project parameters for MDX docs
       let { parameters } = this.storyStoreValue.projectAnnotations;