-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Drop unneeded UPDATE_STORY_ARGS
which was for SSv6
#25993
Conversation
@tmeasday Can I help you somehow bring this over to the finish line? :) |
Hmm, oh I had let this one slip. @valentinpalkovic I think technically this would be a breaking change so we might need to wait for SB9 to drop it - WDYT? Or maybe not, I guess it was a internal thing that we had there for SSv6 mode, maybe given it's undocumented we are allowed to drop it without doing a major. I can rebase the PR and get it passing if so. |
Even if it is technically a breaking change, I would still go forward with merging it if the likelihood that this API was used is low. If people are complaining we can always revert the change and release another hotfix release. |
eef4a3d
to
ff421cb
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5bc5c11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
UPDATE_STORY_ARGS
which was there for SSv6 and back-compat.UPDATE_STORY_ARGS
which was there for SSv6
UPDATE_STORY_ARGS
which was there for SSv6UPDATE_STORY_ARGS
which was for SSv6
What I did
Removed
UPDATE_STORY_ARGS
that was unneeded. See tests.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>