Installing Storybook 2.35.3 results in babel deprecation warning #756

kaiyoma · 2017-04-11T01:12:27Z

Here are the relevant portions of my package.json:

  "dependencies": {
    "babel-plugin-transform-runtime": "~6.23.0",
    "babel-polyfill": "~6.23.0",
    "classnames": "~2.2.3",
    "react-icons": "~2.2.3",
    "react-pure-render": "~1.0.2"
  },
  "devDependencies": {
    "@kadira/storybook": "~2.35.3",
    "babel-cli": "~6.24.1",
    "babel-core": "~6.24.1",
    "babel-eslint": "~7.2.1",
    "babel-preset-es2015": "~6.24.1",
    "babel-preset-react": "~6.24.1",
    "babel-preset-stage-0": "~6.24.1",
    "chai": "~3.5.0",
    "chai-enzyme": "~0.6.1",
    "css-loader": "~0.28.0",
    "enzyme": "~2.8.0",
    "eslint": "~2.10.2",
    "eslint-config-arista": "0.0.1",
    "file-loader": "~0.11.1",
    "jsdom": "~9.12.0",
    "less": "~2.7.2",
    "less-loader": "~4.0.3",
    "lesshint": "~3.1.1",
    "mocha": "~3.2.0",
    "mocha-jenkins-reporter": "~0.3.7",
    "react": "~15.4.2",
    "react-addons-test-utils": "~15.4.2",
    "react-dom": "~15.4.2",
    "sinon": "~2.1.0",
    "style-loader": "~0.16.1",
    "url-loader": "~0.5.7",
    "webpack": "~2.3.3"
  }

If I blow away node_modules and perform a clean npm install, I get this warning:

npm WARN deprecated babel-preset-latest@6.16.0: 💥  preset-latest accomplishes the same task as babel-preset-env. 🙏  Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env 👌. And let us know how you're liking Babel at @babeljs on 🐦

I'm not installing babel-preset-latest or babel-preset-env directly; they're both coming from Storybook. Please let me know if you need any more info.

The text was updated successfully, but these errors were encountered:

ndelangen · 2017-04-12T22:15:12Z

Thanks for the report!

ndelangen · 2017-04-27T22:40:46Z

I've worked on moving devDependencies to the root today, mostly babel. So Will need to check if this is still something that happens. I'm not getting any error-messages like this.

ndelangen · 2017-04-27T22:41:40Z

If someone could check if this still happens and if so when, that'd be a great help!

kaiyoma · 2017-04-27T23:08:08Z

I'm happy to help out, but I don't see any releases after 2.35.3, which is the version I'm installing that exhibits this issue. (I also don't see any commits to this issue.)

ndelangen · 2017-04-28T07:03:01Z

Hey thanks @kaiyoma !

We recently moved to a monorepo structure managed by lerna.
What you can do to help is reproduce the issue like this:

Clone the repo

perform an npm install (this should bootstrap lerna)
If it fails initially, retry it by running npm install again. (I'm working on that issue).
It should roughly look like this:

➜  react-storybook git:(master) yarn
yarn install v0.22.0
[1/4] 🔍  Resolving packages...
success Already up-to-date.
$ lerna bootstrap --hoist
Lerna v2.0.0-rc.3
Encountered a cycle in the dependency graph. This may cause instability!
Bootstrapping 19 packages
Preinstalling packages
Installing external dependencies
Symlinking packages and binaries
Postinstalling packages
Prepublishing packages
Successfully bootstrapped 19 packages.
✨  Done in 62.68s.

Go to /examples/test-cra/
Make whatever changes to need to to reproduce the problem.
Share how you reproduced the problem, if simple by a message, if complex a branch I can look at is preferred

Thanks so much! Let me know if you need help.

kaiyoma · 2017-04-28T19:07:53Z

I can't repro the issue by cloning the repo and installing. To repro the issue, you have to install storybook from inside another project. You can do so with this barebones config:

package.json:

{
  "name": "test",
  "devDependencies": {
    "@kadira/storybook": "2.35.3",
    "react": "15.0.0",
    "react-dom": "15.0.0"
  }
}

.npmrc:

@kadira:registry=https://registry.npmjs.org/

When you npm install, the first line of output will be the babel warning.

ndelangen · 2017-04-28T20:52:42Z

Right so that will install an older version, I'd love to know if what's on master still exhibits this behavior..

kaiyoma · 2017-04-28T21:09:25Z

I wonder if that requires some npm link magic? I'm not familiar with that process, so if you have some steps to follow, let me know.

See #756 (comment) We should actually ensure this works consistently for people before making this change.

diegohaz · 2017-05-01T11:11:53Z

I'm seeing this warning related to babel-preset-react-app:

ndelangen · 2017-05-10T05:45:01Z

Looks like we're using babel-preset-latest somewhere we should be using babel-preset-env

ndelangen · 2017-05-10T09:39:54Z

@diegohaz Do you think you could try it with this branch? #1008

ndelangen · 2017-05-10T09:42:24Z

@kaiyoma We now have some steps described here: https://github.com/storybooks/storybook/blob/master/CONTRIBUTING.md#testing-against-master

I hope this helps you reproduce the issue.

kaiyoma · 2017-05-10T18:00:51Z

I'm getting an error when running npm install inside storybook:

$ npm install
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.1.1: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm ERR! Windows_NT 10.0.15063
npm ERR! argv "C:\\Program Files\\Node.js\\node.exe" "C:\\Program Files\\Node.js\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.9
npm ERR! code E404

npm ERR! 404 no such package available : @types/react
npm ERR! 404
npm ERR! 404  '@types/react' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of 'jest-enzyme'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

ndelangen · 2017-05-10T22:04:52Z

How?! https://www.npmjs.com/package/@types/react

kaiyoma · 2017-05-10T22:15:13Z

In my team's project, we need an entry in our .npmrc to be able to install Storybook:

@kadira:registry=https://registry.npmjs.org/

Maybe you need the same thing in your source tree?

ndelangen · 2017-05-11T11:12:05Z

Looking at your log, It's clear the package it's failing to install is a dependency of 'jest-enzyme'.
I'm guessing you need to map:

@types:registry=https://registry.npmjs.org/

I have no idea why this would be necessary, your node & npm versions seem fine to me.

kaiyoma · 2017-05-11T17:37:37Z

Adding .npmrc with the line above fixed the install issue. I'm guessing you guys need to add that file as part of your project?

In the interest of full helpfulness, I noticed a few (probably benign) warnings during the installation:

npm WARN deprecated fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support
...
npm WARN storybook@ No repository field.
npm WARN storybook@ No license field.

During npm run bootstrap, I encountered resolution errors similar to the ones we saw before:

lerna ERR! execute npm ERR! 404 no such package available : @kadira/storybook-addon-links

However, this time, adding a line to .npmrc does not fix the issue. Here's my .npmrc now:

@kadira:registry=https://registry.npmjs.org/
@types:registry=https://registry.npmjs.org/

And here's what happens when I try npm run bootstrap:

lerna ERR! execute Error: Command failed: npm install
lerna ERR! execute npm ERR! Windows_NT 10.0.15063
lerna ERR! execute npm ERR! argv "C:\\Program Files\\Node.js\\node.exe" "C:\\Program Files\\Node.js\\node_modules\\npm\\bin\\npm-cli.js" "install"
lerna ERR! execute npm ERR! node v6.9.1
lerna ERR! execute npm ERR! npm  v3.10.9
lerna ERR! execute npm ERR! code E404
lerna ERR! execute
lerna ERR! execute npm ERR! 404 no such package available : @kadira/storybook-addon-links
lerna ERR! execute npm ERR! 404
lerna ERR! execute npm ERR! 404  '@kadira/storybook-addon-links' is not in the npm registry.
lerna ERR! execute npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
lerna ERR! execute npm ERR! 404
lerna ERR! execute npm ERR! 404 Note that you can also install from a
lerna ERR! execute npm ERR! 404 tarball, folder, http url, or git url.

That error repeats about 4 times and I also see this:

npm ERR! 404 no such package available : @kadira/storybook-deployer

Any ideas?

(BTW, how come you guys require the @kadira at all? I haven't seen that with any of the other dozens of NPM packages that we use.)

ndelangen · 2017-05-11T17:59:13Z

Hey @kaiyoma, I'm at a loss..

The .npmrc stuff you apparently need to do is not normal, It's not something everyone needs to do because https://registry.npmjs.org/ is the default registry of npm.
I have no idea why you have to add all organisations to your .npmrc file like that.

I'm aware of this one:

npm WARN deprecated fs-promise@2.0.3: Use mz or fs-extra^3.0 with Promise Support

But these are unknown to me:

npm WARN storybook@ No repository field.

We're migrating away from the @kadira organisation to a @storybook organisation on npm. But this is still in progress.

kaiyoma · 2017-05-11T18:04:37Z

We have an internal NPM registry here at my organization. Would that explain things?

ndelangen · 2017-05-11T18:54:49Z

Yeah that would have to be it! Maybe you you can ask for support there.

At my current client (unrelated to storybook), we're using artifactory as a custom registry, and it's able to pass though to the regular registry (including organisations) just fine.

kaiyoma · 2017-05-11T21:03:30Z

Our internal repository does the same thing actually. I'm wondering if the lerna layer requires more configuration to resolve all the names. In any case, I'll try testing master on my personal laptop later, which will be much easier than wrangling with my work environment.

kaiyoma · 2017-05-12T03:38:11Z

I'm running into issues on my personal laptop as well. I believe I made it past the name resolution part and I'm now seeing an error relating to a missing directory:

$ npm run bootstrap

> storybook@ bootstrap C:\Users\Kyle\Downloads\storybook
> lerna bootstrap

lerna info version 2.0.0-rc.4
lerna info ignore [ 'test-cra' ]
lerna WARN ECYCLE Encountered a cycle in the dependency graph. This may cause instability!
lerna info Bootstrapping 18 packages
lerna info lifecycle preinstall
lerna info Installing external dependencies
lerna info Symlinking packages and binaries
lerna ERR! execute Error: ENOENT: no such file or directory, stat 'C:\Users\Kyle\Downloads\storybook\packages\react-storybook\dist\server\build.js'
lerna ERR! execute     at Error (native)
lerna ERR! execute  callback with error
lerna ERR! execute  { Error: ENOENT: no such file or directory, stat 'C:\Users\Kyle\Downloads\storybook\packages\react-storybook\dist\server\build.js'
lerna ERR! execute     at Error (native)
lerna ERR! execute   errno: -4058,
lerna ERR! execute   code: 'ENOENT',
lerna ERR! execute   syscall: 'stat',
lerna ERR! execute   path: 'C:\\Users\\Kyle\\Downloads\\storybook\\packages\\react-storybook\\dist\\server\\build.js' }

I looked at the directory structure manually and I can verify that there is definitely no dist directory underneath storybook/packages/react-storybook:

$ ll packages/react-storybook/
total 306
-rw-r--r-- 1 Kyle 197121   218 May 11 20:10 addons.js
-rw-r--r-- 1 Kyle 197121 28663 May 11 20:10 CHANGELOG.md
-rw-r--r-- 1 Kyle 197121  3225 May 11 20:10 CODE_OF_CONDUCT.md
drwxr-xr-x 1 Kyle 197121     0 May 11 20:10 config/
drwxr-xr-x 1 Kyle 197121     0 May 11 20:10 demo/
drwxr-xr-x 1 Kyle 197121     0 May 11 20:10 docs/
-rw-r--r-- 1 Kyle 197121  1096 May 11 20:10 LICENSE
drwxr-xr-x 1 Kyle 197121     0 May 11 20:22 node_modules/
-rw-r--r-- 1 Kyle 197121  2301 May 11 20:10 package.json
-rw-r--r-- 1 Kyle 197121  1830 May 11 20:10 README.md
-rw-r--r-- 1 Kyle 197121   290 May 11 20:10 ROADMAP.md
drwxr-xr-x 1 Kyle 197121     0 May 11 20:10 scripts/
drwxr-xr-x 1 Kyle 197121     0 May 11 20:10 src/

ndelangen · 2017-05-17T18:12:04Z

This will be a known issue in the 3.0.0-alpha.0 release

mbarragana · 2017-05-19T10:27:47Z

It seems that babel-preset-react-app is still using babel-preset-latest, but I could not find it

ndelangen · 2017-05-22T21:07:38Z

When I do a clean CRA install and then add storybook via cli, I do not get this message anymore.

See #756 (comment) We should actually ensure this works consistently for people before making this change.

AkanWealth · 2018-06-29T23:56:42Z

npm ERR! code E404
npm ERR! 404 Not Found: bable-preset-env@latest
npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\HP PC\AppData\Roaming\npm-cache_logs\2018-06-30T08_40_00_824Z-debug.log
how do i install babel-cli babel-preset-env

kaiyoma · 2018-06-30T00:28:59Z

Did you copy that output exactly? Because you have a typo here:

npm ERR! 404 Not Found: bable-preset-env@latest

That should be babel-preset-env.

AkanWealth · 2018-06-30T00:40:27Z

thanks for that i will rerun it

ndelangen added dependencies help wanted labels Apr 12, 2017

ndelangen added this to the v3.0.0 milestone Apr 12, 2017

ndelangen added the ready label Apr 12, 2017

ndelangen self-assigned this Apr 27, 2017

ndelangen added needs reproduction good first issue and removed help wanted ready labels Apr 27, 2017

tmeasday pushed a commit that referenced this issue May 1, 2017

First pass at update the contribution instructions

9b59092

See #756 (comment) We should actually ensure this works consistently for people before making this change.

tmeasday mentioned this issue May 1, 2017

First pass at update the contribution instructions #982

Merged

ndelangen modified the milestones: v3.0.1, v3.0.0 May 17, 2017

ndelangen closed this as completed May 22, 2017

ndelangen pushed a commit that referenced this issue May 24, 2017

First pass at update the contribution instructions

4f096c5

See #756 (comment) We should actually ensure this works consistently for people before making this change.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installing Storybook 2.35.3 results in babel deprecation warning #756

Installing Storybook 2.35.3 results in babel deprecation warning #756

kaiyoma commented Apr 11, 2017

ndelangen commented Apr 12, 2017

ndelangen commented Apr 27, 2017

ndelangen commented Apr 27, 2017

kaiyoma commented Apr 27, 2017 •

edited

Loading

ndelangen commented Apr 28, 2017

kaiyoma commented Apr 28, 2017

ndelangen commented Apr 28, 2017

kaiyoma commented Apr 28, 2017

diegohaz commented May 1, 2017

ndelangen commented May 10, 2017

ndelangen commented May 10, 2017 •

edited

Loading

ndelangen commented May 10, 2017

kaiyoma commented May 10, 2017

ndelangen commented May 10, 2017

kaiyoma commented May 10, 2017

ndelangen commented May 11, 2017

kaiyoma commented May 11, 2017

ndelangen commented May 11, 2017

kaiyoma commented May 11, 2017

ndelangen commented May 11, 2017 •

edited

Loading

kaiyoma commented May 11, 2017

kaiyoma commented May 12, 2017

ndelangen commented May 17, 2017

mbarragana commented May 19, 2017

ndelangen commented May 22, 2017

AkanWealth commented Jun 29, 2018

kaiyoma commented Jun 30, 2018

AkanWealth commented Jun 30, 2018

Installing Storybook 2.35.3 results in babel deprecation warning #756

Installing Storybook 2.35.3 results in babel deprecation warning #756

Comments

kaiyoma commented Apr 11, 2017

ndelangen commented Apr 12, 2017

ndelangen commented Apr 27, 2017

ndelangen commented Apr 27, 2017

kaiyoma commented Apr 27, 2017 • edited Loading

ndelangen commented Apr 28, 2017

kaiyoma commented Apr 28, 2017

ndelangen commented Apr 28, 2017

kaiyoma commented Apr 28, 2017

diegohaz commented May 1, 2017

ndelangen commented May 10, 2017

ndelangen commented May 10, 2017 • edited Loading

ndelangen commented May 10, 2017

kaiyoma commented May 10, 2017

ndelangen commented May 10, 2017

kaiyoma commented May 10, 2017

ndelangen commented May 11, 2017

kaiyoma commented May 11, 2017

ndelangen commented May 11, 2017

kaiyoma commented May 11, 2017

ndelangen commented May 11, 2017 • edited Loading

kaiyoma commented May 11, 2017

kaiyoma commented May 12, 2017

ndelangen commented May 17, 2017

mbarragana commented May 19, 2017

ndelangen commented May 22, 2017

AkanWealth commented Jun 29, 2018

kaiyoma commented Jun 30, 2018

AkanWealth commented Jun 30, 2018

kaiyoma commented Apr 27, 2017 •

edited

Loading

ndelangen commented May 10, 2017 •

edited

Loading

ndelangen commented May 11, 2017 •

edited

Loading