First pass at update the contribution instructions

[tmeasday]

See #756 (comment)

We should actually ensure this works consistently for people before making this change.

[codecov]

Codecov Report

Merging #982 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage    12.6%   12.61%   +<.01%     
==========================================
  Files         192      192              
  Lines        4426     4447      +21     
  Branches      707      710       +3     
==========================================
+ Hits          558      561       +3     
- Misses       3243     3258      +15     
- Partials      625      628       +3

Impacted Files	Coverage Δ
packages/addon-knobs/src/components/PropField.js	11.59% <0%> (+1.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5affcbd...037453d. Read the comment docs.

[shilman]

Tested and these instructions look good to me.

However I am not sure about the difference between test-cra and cra-storybook. Storybook works in both directories, but npm start only works for me in cra-storybook. @ndelangen any input here?

[shilman]

My error for npm start in test-cra:

Failed to compile.

Error in   TypeError: Cannot read property '0' of undefined
  
  - ExternalModuleFactoryPlugin.js:19 
    [test-cra]/[webpack]/lib/ExternalModuleFactoryPlugin.js:19:40
  
  - NormalModuleFactory.js:159 
    [test-cra]/[react-scripts]/[webpack]/lib/NormalModuleFactory.js:159:3
  
  - Tapable.js:75 NormalModuleFactory.applyPluginsAsyncWaterfall
    [test-cra]/[react-scripts]/[tapable]/lib/Tapable.js:75:69
  
  - NormalModuleFactory.js:144 NormalModuleFactory.create
    [test-cra]/[react-scripts]/[webpack]/lib/NormalModuleFactory.js:144:8
  
  - Compilation.js:356 Compilation.process [as _addModuleChain]
    [test-cra]/[react-scripts]/[webpack]/lib/Compilation.js:356:16
  
  - Compilation.js:424 Compilation.process [as addEntry]
    [test-cra]/[react-scripts]/[webpack]/lib/Compilation.js:424:7
  
  - SingleEntryPlugin.js:24 Compiler.compiler.plugin
    [test-cra]/[webpack]/lib/SingleEntryPlugin.js:24:16
  
  - Tapable.js:107 Compiler.applyPluginsParallel
    [test-cra]/[react-scripts]/[tapable]/lib/Tapable.js:107:14
  
  - Compiler.js:394 Compiler.compile
    [test-cra]/[react-scripts]/[webpack]/lib/Compiler.js:394:7
  
  - Compiler.js:203 Compiler.runAsChild
    [test-cra]/[react-scripts]/[webpack]/lib/Compiler.js:203:7
  
  - compiler.js:70 
    [test-cra]/[html-webpack-plugin]/lib/compiler.js:70:19
  
  - compiler.js:69 Object.compileTemplate
    [test-cra]/[html-webpack-plugin]/lib/compiler.js:69:10
  
  - index.js:47 Compiler.<anonymous>
    [test-cra]/[html-webpack-plugin]/index.js:47:40

[usulpro]

At this moment when I npm install it only installs root dependencies. In order to install all packages, I need to run npm run bootstrap.
OS: Windows. So I can't tell is it common or only windows issue (but previosly npm install started to install everything inside packages folder)

[tmeasday]

@ndelangen where are we at with fixing this problem? Should we update these instructions or will it be sorted soon?

[ndelangen]

This should be changed so npm run bootstrap is a required step.

I changed this because bootstrapping is not always needed when adding a root dependency for example, but it does take a huge amount of time.

[ndelangen]

I added it

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 037453d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run-many -t build -c production --parallel=3

---

Sent with 💌 from NxCloud.