Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: Expose ReactFramework type #19704

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Nov 1, 2022

Issue: N/A

What I did

Re-exported the type ReactFramework from @storybook/react, to support uses like @storybook/testing-react in storybookjs/testing-react#120. I think it wasn't intentionally made private.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS requested a review from kasperpeulen November 1, 2022 20:12
@IanVS IanVS changed the title Expose ReactFramework type React: Expose ReactFramework type Nov 1, 2022
@kasperpeulen kasperpeulen merged commit 426c6c0 into next Nov 2, 2022
@kasperpeulen kasperpeulen deleted the export-react-framework branch November 2, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants