-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
Socket Security Pull Request ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
😵💫 Bin script confusionThis package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack Consider removing one of the conflicting packages. Packages should only export bin scripts with their name
Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
@shilman what do you say we try the new branch strategy in this package too? |
This is blocked on storybookjs/storybook#19704, I believe. |
It looks like the types here have diverged quite a bit from storybook 7. Now I'm seeing an error of:
I'm not familiar enough with what's changed to fix this, unfortunately. |
I upgraded the example and fixed most of the issues, the only remaining one is the type for Also, feel free to test the resulting canary in your project: |
🚀 PR was released in |
Issue: #118, #119, #111
closes #116
What Changed
This attempts to create a version of @storybook/testing-react that is compatible with the latest 7.0 alpha versions. So far, though, I'm a bit hung up on the types. Maybe @kasperpeulen can help me out. The current issue I've hit is that
ReactFramework
is no longer exported from@storybook/react
, and I don't see it being exported anywhere else, either.Checklist
Check the ones applicable to your change:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major
Release Notes
💥 Breaking Change
This version adds support for Storybook 7.0. It requires you to be using Storybook 7.0, as there were several internal changes required, all of which depend on new Storybook packages.
🚀 Features
In Storybook 7.0, the play function can also be defined in the Meta (default export). This is now supported in
@storybook/testing-react
.The
setGlobalConfig
function is now deprecated in favor ofsetProjectAnnotations
, which aligns better with Storybook 7.0 nomenclature.From:
To:
📦 Published PR as canary version:
2.0.0--canary.120.dce8fc8.0
✨ Test out this PR locally via:
npm install @storybook/testing-react@2.0.0--canary.120.dce8fc8.0 # or yarn add @storybook/testing-react@2.0.0--canary.120.dce8fc8.0
Version
Published prerelease version:
v2.0.0-next.0
Changelog
Release Notes
Support Storybook 7.0 (#120)
💥 Breaking Change
This version adds support for Storybook 7.0. It requires you to be using Storybook 7.0, as there were several internal changes required, all of which depend on new Storybook packages.
🚀 Features
In Storybook 7.0, the play function can also be defined in the Meta (default export). This is now supported in
@storybook/testing-react
.The
setGlobalConfig
function is now deprecated in favor ofsetProjectAnnotations
, which aligns better with Storybook 7.0 nomenclature.From:
To:
💥 Breaking Change
Authors: 3