-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Upgrade manager to react 18 #21673
UI: Upgrade manager to react 18 #21673
Conversation
For your reading pleasure, the test suite output Click for output of `yarn test`
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
getting there
|
not sure what to do about enzyme yet. It's dead upstream, last adapter was for react-16, and it doesn't really work for react-18 https://darekkay.com/blog/react-18-enzyme/ might just whack that stuff since everybody should switch to RTL anyway? |
technically just one test failing now
also these two report problems that don't result in failure but maybe should
haven't investigated further yet |
This is just the first step. Lots of stuff borked ``` yarn up react @types/react @types/react-dom @testing-library/react ``` Immediate issues with mismatched react-dom that wasn't listed explicitly in package.json before, so ``` yarn add react-dom ```
5b428e3
to
f66e38a
Compare
rebased to next |
I'm not going to keep rebasing this (because it's annoying, as rebasing dependency updates always is) but this PR could probably be recreated by a willing individual as a couple of separate PRs to make things easier:
|
Either way, thanks for your persistence in this @agriffis, and for thinking about next steps. Great work here. ❤️ |
Yes, there's a desire among Storybook maintainers to remove the use of Enzyme from our codebase. |
I telescoped this PR to |
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @types/react@16.14.49, @types/react-dom@16.9.20 |
code/lib/preview-api/src/modules/preview-web/PreviewWeb.integration.test.ts
Outdated
Show resolved
Hide resolved
uhmm.. github? I would like to target the new branch of course.. not close this PR?! |
Closes #20378 #22217
What i did:
Upgrade react and some testing deps then fix the fallout.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]