Toolbars: Fix title behavior in UI #22496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
Reported here https://discord.com/channels/486522875931656193/1105749672489918506
What I did
There's a bug in Storybook 7 where the toolbar button automatically shows a text label even if no
title
is specified in the toolbar configuration. It also makes a deprecation warning in the console. This PR fixes that. Now if the user doesn't specify atitle
attribute for the toolbar, no label is shown, and no deprecation warning is shown.It also fixes a few other minor bugs in the same code:
title
oricon
is specified, it will warn in the browser consolereset
toolbar itemdynamicTitles
is setSelf-merging @valentinpalkovic
How to test
Run a sandbox and check out the toolbar. In the current code both
Theme
andLocale
will show up as labels. With this PR, theLocale
label goes away since it's not configured in the project.