Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: add compatibility with Next 13.4.3 #22697

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented May 23, 2023

Closes #22686

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch nextjs ci:daily Run the CI jobs that normally run in the daily job. labels May 23, 2023
@yannbf yannbf requested a review from valentinpalkovic May 23, 2023 10:23
@yannbf yannbf self-assigned this May 23, 2023
@yannbf yannbf changed the title CLI: Introduce node polyfills in next.js framework Next.js: Introduce node polyfills May 23, 2023
@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again.

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore tty-browserify@0.0.1
  • @SocketSecurity ignore assert@2.0.0
⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
tty-browserify@0.0.1 (added) goto-bus-stop substack code/frameworks/nextjs/package.json via node-polyfill-webpack-plugin@2.0.1
assert@2.0.0 (added) lukechilds goto-bus-stop code/frameworks/nextjs/package.json via node-polyfill-webpack-plugin@2.0.1
Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ⚠️ 2 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
node-polyfill-webpack-plugin@2.0.1 network +7 richienb

@yannbf yannbf changed the title Next.js: Introduce node polyfills Next.js: add compatibility with Next 13.4.3 May 23, 2023
@ndelangen ndelangen merged commit cd4155b into next May 23, 2023
@ndelangen ndelangen deleted the fix/nextjs-node-polyfills branch May 23, 2023 11:30
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 23, 2023
shilman pushed a commit that referenced this pull request May 23, 2023
Next.js: add compatibility with Next 13.4.3
This was referenced May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. nextjs patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/nextjs incompatible with Next 13.4.3
4 participants