CLI: Fix upgrade notification message #22933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
cli
patch:yes
JReinhold
approved these changes
Jun 6, 2023
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jun 6, 2023
…tification CLI: Fix upgrade notification message
This was referenced Jun 7, 2023
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N/A
What I did
When the upgrade notification check succeeds, we tell the user to upgrade.
The upgrade message is wrong, however. If the upgrade version is stable, it should be
npx storybook@latest upgrade. If the upgrade version is a prerelease, it should benpx storybook@next upgrade --prerelease.That's because the
@nextrelease might contain logic & automigrations that are specific to the next release.Note that this logic assumes that all prereleases are on the
nextdist tag, which might not be the case in the future. Also this should be updated when we overhaul the CLI @JReinhold