-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: New release tooling #22959
Release: New release tooling #22959
Conversation
Quick reminder that the branch structure changes done in this PR need to be accounted for in the status-page |
Thanks @yannbf, I've had that in the back of my head for a while. I might just go with the current branch structure honestly, because |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
…k into new-release-tooling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Release: New release tooling
Release: New release tooling
Release: New release tooling
Release: New release tooling
Release: New release tooling
Works on #22532. This PR is too big to summarize, but it basically implements the whole plan laid out in the RFC for release tooling: #22182
What I did
scripts/release
that are Node CLI scripts to support the new release workflowHow to test
My initial plan of attack here:
NPM_TOKEN
in GitHub secrets yet.NPM_TOKEN
secret and rerun the publish workflow.Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]