-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix builder-manager
adding multiple dashes to relative path
#22974
Merged
ndelangen
merged 3 commits into
storybookjs:next
from
MarioCadenas:fix/build-manager-path-generation
Jun 8, 2023
Merged
Core: Fix builder-manager
adding multiple dashes to relative path
#22974
ndelangen
merged 3 commits into
storybookjs:next
from
MarioCadenas:fix/build-manager-path-generation
Jun 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Jun 8, 2023
ndelangen
added
bug
patch:yes
Bugfix & documentation PR that need to be picked to main branch
labels
Jun 8, 2023
Thank you @MarioCadenas ! |
A pleasure! thanks for the fast review! 😄 |
JReinhold
changed the title
fix: Build manager adding multiple dashes to relative path
Fix: Jun 9, 2023
builder-manager
adding multiple dashes to relative path
JReinhold
changed the title
Fix:
Core: Fix Jun 9, 2023
builder-manager
adding multiple dashes to relative pathbuilder-manager
adding multiple dashes to relative path
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
Merged
69 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
…neration fix: Build manager adding multiple dashes to relative path (cherry picked from commit 7f1ffa7)
JReinhold
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Jun 15, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
When building a standalone storybook, using the function
buildStaticStandalone
and having a manager.ts inside the main configDir of storybook, the folder generated inside the storybook/sb-addons that contains the manager bundle in some cases might get into the functionsanitizeBase
as a relative path, example../../my-module/some-path/foo/bar
and after getting the result from sanitizeBase it would be
--my-module-some-path-foo-bar
The problem with this is that uploading a folder like this to S3 makes it a problem and is not accessible. So this PR basically removes the dashes in case they exist. So in the previous example it would return
my-module-some-path-foo-bar
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]