Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Upgrade playwright to 1.35.0 #22992

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Build: Upgrade playwright to 1.35.0 #22992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ executors:
default: 'small'
working_directory: /tmp/storybook
docker:
- image: mcr.microsoft.com/playwright:v1.34.3-focal
- image: mcr.microsoft.com/playwright:v1.35.0-focal
environment:
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
Expand Down
4 changes: 2 additions & 2 deletions code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"defaults"
],
"resolutions": {
"@playwright/test": "1.34.3",
"@playwright/test": "1.35.0",
"@typescript-eslint/eslint-plugin": "^5.45.0",
"@typescript-eslint/experimental-utils": "^5.45.0",
"@typescript-eslint/parser": "^5.45.0",
Expand All @@ -97,7 +97,7 @@
"@emotion/jest": "^11.10.0",
"@jest/globals": "^29.3.1",
"@nx/workspace": "16.2.1",
"@playwright/test": "^1.34.3",
"@playwright/test": "^1.35.0",
"@storybook/addon-a11y": "workspace:*",
"@storybook/addon-actions": "workspace:*",
"@storybook/addon-backgrounds": "workspace:*",
Expand Down
21 changes: 15 additions & 6 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4860,19 +4860,19 @@ __metadata:
languageName: node
linkType: hard

"@playwright/test@npm:1.34.3":
version: 1.34.3
resolution: "@playwright/test@npm:1.34.3"
"@playwright/test@npm:1.35.0":
version: 1.35.0
resolution: "@playwright/test@npm:1.35.0"
dependencies:
"@types/node": "*"
fsevents: 2.3.2
playwright-core: 1.34.3
playwright-core: 1.35.0
dependenciesMeta:
fsevents:
optional: true
bin:
playwright: cli.js
checksum: b87b3666568378997e6e300c28a5062d099377f66894c2d30855ef0b574a0874f5e4e6e7d25d93f1db1e5e402ccc1a254a1c24ec829a64ec47b4c8071082c9a7
checksum: 77594d876632e9ce8a33851fed0a9ffe1034ca216811a3b5c3925c371eddb20ceb6848f3e9b10234a025dcf7be979cddcd0285ad627ad30afbc0cf246ab74c4d
languageName: node
linkType: hard

Expand Down Expand Up @@ -7063,7 +7063,7 @@ __metadata:
"@emotion/jest": ^11.10.0
"@jest/globals": ^29.3.1
"@nx/workspace": 16.2.1
"@playwright/test": ^1.34.3
"@playwright/test": ^1.35.0
"@storybook/addon-a11y": "workspace:*"
"@storybook/addon-actions": "workspace:*"
"@storybook/addon-backgrounds": "workspace:*"
Expand Down Expand Up @@ -24503,6 +24503,15 @@ __metadata:
languageName: node
linkType: hard

"playwright-core@npm:1.35.0":
version: 1.35.0
resolution: "playwright-core@npm:1.35.0"
bin:
playwright-core: cli.js
checksum: 157257f0950190903d75ff6af70258fe1b1c6bf44f144a063428a594c09b4631d4c151ff65e28e1d9fc13edd8bd51c4720a7d87fc755c2afba47f41919bf5875
languageName: node
linkType: hard

"playwright@npm:^1.24.2":
version: 1.34.3
resolution: "playwright@npm:1.34.3"
Expand Down
2 changes: 1 addition & 1 deletion scripts/utils/yarn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
// this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
'@playwright/test': '^1.34.3',
'@playwright/test': '^1.35.0',
};
await writeJSON(packageJsonPath, packageJson, { spaces: 2 });
};
Expand Down