Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Upgrade playwright to 1.35.0 #22992

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 9, 2023

No description provided.

@shilman shilman requested a review from a team as a code owner June 9, 2023 03:58
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jun 9, 2023
@shilman shilman force-pushed the shilman/upgrade-playwright branch from 04121e3 to c725b46 Compare June 9, 2023 04:14
@ndelangen
Copy link
Member

ndelangen commented Jun 9, 2023

@shilman the bench addon repo needs to be updated as well?

actually.. the addon should always install the latest:
https://github.com/storybookjs/bench/blob/next/package.json#L48

I don't think this script impacts the bench:

packageJson.resolutions = {
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
// this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
'@playwright/test': '^1.35.0',
};

@ndelangen
Copy link
Member

I'll merge this as-is even though the CI is failing, because it removes some CI failings on next.

I'll continue investigating why the bench is failing, and open a follow-up PR asap.

@ndelangen ndelangen changed the title Upgrade playwright to 1.35.0 Build: Upgrade playwright to 1.35.0 Jun 9, 2023
@ndelangen ndelangen merged commit 10e6a67 into next Jun 9, 2023
@ndelangen ndelangen deleted the shilman/upgrade-playwright branch June 9, 2023 07:26
kasperpeulen pushed a commit that referenced this pull request Jun 9, 2023
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
69 tasks
shilman pushed a commit that referenced this pull request Jun 13, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 13, 2023
shilman pushed a commit that referenced this pull request Jun 13, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
kasperpeulen pushed a commit that referenced this pull request Jun 13, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
@shilman shilman removed the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 14, 2023
shilman pushed a commit that referenced this pull request Jun 14, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
kasperpeulen pushed a commit that referenced this pull request Jun 14, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
kasperpeulen pushed a commit that referenced this pull request Jun 14, 2023
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants