Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Release tooling for main #23008

Merged
merged 7 commits into from
Jun 9, 2023
Merged

Build: Release tooling for main #23008

merged 7 commits into from
Jun 9, 2023

Conversation

kasperpeulen
Copy link
Contributor

Closes #

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen requested a review from JReinhold June 9, 2023 13:35
@kasperpeulen kasperpeulen force-pushed the release-tooling-for-main branch from 62c9451 to 554e781 Compare June 9, 2023 13:36
JReinhold added 4 commits June 9, 2023 15:40
Release: Fix minor scripts and workflows
Release: Don't pick patches when prereleasing
Release: Don't reference prototype repository
@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
New author clone-response 1.0.3 scripts/package.json via danger@11.2.6
New author responselike 2.0.1 scripts/package.json via danger@11.2.6
Shell access simple-git 3.19.0 scripts/package.json

Next steps

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore simple-git@3.19.0
  • @SocketSecurity ignore clone-response@1.0.3
  • @SocketSecurity ignore responselike@2.0.1

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
danger 🆕 11.2.6 environment +20 3.75 MB orta
p-retry 🆕 5.1.2 None +1 20.6 kB sindresorhus
wait-on 🆕 7.0.1 None +1 480 kB jeffbski
@actions/core 🆕 1.10.0 network, filesystem, environment +2 209 kB thboop
dataloader 🆕 2.2.2 None +0 62.2 kB saihaj
jest-mock-extended 🆕 3.0.4 None +1 144 kB marchaos
simple-git 🆕 3.19.0 filesystem, shell +2 898 kB steveukx

Footnotes

  1. https://docs.socket.dev

Release: Fix permissions for publish script
Release: Fix not escaping content of GH Releases
@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Jun 9, 2023
@kasperpeulen kasperpeulen merged commit f5cf05f into main Jun 9, 2023
@kasperpeulen kasperpeulen deleted the release-tooling-for-main branch June 9, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants