Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeowners: Add file #23519

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

valentinpalkovic
Copy link
Contributor

Closes N/A

What I did

Created a CODEOWNERS file

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Jul 19, 2023
@valentinpalkovic valentinpalkovic self-assigned this Jul 19, 2023
@valentinpalkovic valentinpalkovic force-pushed the valentin/create-code-ownership-file branch 8 times, most recently from ac7a617 to 88f99ae Compare July 19, 2023 15:02
@valentinpalkovic valentinpalkovic requested a review from a team July 19, 2023 15:02
@valentinpalkovic valentinpalkovic marked this pull request as ready for review July 19, 2023 15:03
@valentinpalkovic valentinpalkovic added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jul 19, 2023
@valentinpalkovic valentinpalkovic changed the title Add Codeowners file CODEOWNERS: Add Codeowners file Jul 19, 2023
@valentinpalkovic valentinpalkovic changed the title CODEOWNERS: Add Codeowners file Codeowners: Add Codeowners file Jul 19, 2023
@valentinpalkovic valentinpalkovic changed the title Codeowners: Add Codeowners file Codeowners: Add file Jul 19, 2023
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see @kylegach mentioned a couple of places where I was suppose to be I think, maybe a faulty search-and-replace @valentinpalkovic ?

CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me!

@valentinpalkovic valentinpalkovic force-pushed the valentin/create-code-ownership-file branch from e92ebdc to 5982cd1 Compare July 20, 2023 07:47
Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Jeppe Reinhold <jeppe@chromatic.com>

Update CODEOWNERS

Co-authored-by: Tom Coleman <tom@chromatic.com>

Update CODEOWNERS

Co-authored-by: Tom Coleman <tom@chromatic.com>

Update CODEOWNERS

Co-authored-by: Tom Coleman <tom@chromatic.com>

Update Codeowners file
@valentinpalkovic valentinpalkovic force-pushed the valentin/create-code-ownership-file branch from 5982cd1 to ecef76a Compare July 20, 2023 07:47
@valentinpalkovic valentinpalkovic merged commit 98432d5 into next Jul 20, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/create-code-ownership-file branch July 20, 2023 07:48
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
14 tasks
storybook-bot pushed a commit that referenced this pull request Jul 20, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 20, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
…ship-file

Codeowners: Add file
(cherry picked from commit 98432d5)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants