Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 7.1.2 #23589

Closed
wants to merge 14 commits into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 25, 2023

This is an automated pull request that bumps the version from 7.1.1 to 7.1.2.
Once this pull request is merged, it will trigger a new release of version 7.1.2.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

  • Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
  • Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

  1. Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
  2. Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
  3. Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
    • Areas include: React, Vue, Core, Docs, Controls, etc.
    • First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
    • The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

  • 📦 Dependencies: Dependencies: Downgrade jest-mock #23597
  • 🐛 Bug: Angular: Fix initialization of Storybook in Angular 16.1 #23598
  • 📦 Dependencies: Dependencies: Upgrade simple-update-notifier #23396
  • 🐛 Bug: NextJS: Add @babel/core as a dependency #22450
  • 🔧 Maintenance: TypeScript: Downgrade to the last version of type-fest that doesn't need typescript 5.0 #23574
  • 🐛 Bug: Core: Fix channelOptions for serverChannel #23615
  • 🐛 Bug: Automigration: Fix wrap-require automigration for common js main.js files #23644
  • 🐛 Bug: CLI: Fix error logging being swallowed from dev/build failures #23689
  • 🏗️ Build: Release tooling: Support canary releases #23508
  • 📝 Documentation: Documentation: Fix snippets regarding module resolution #23602
  • 📝 Documentation: Docs: Minor updates to the Environment variables docs #23605
  • 🏗️ Build: Release tooling: Make canaries use v0.0.0 #23609
  • 🏗️ Build: CI: Add missing workflow enum #23617
  • 🏗️ Build: Build: Migrate mono-repo dependency versions to use yarn workspace syntax #23572
  • 📝 Documentation: docs: replace unsupported value 'string' in controls #23565
  • 🏗️ Build: Codeowners: Fix codeowner docs glob #23610
  • 🏗️ Build: E2E: Fix flaky e2e tests #23630
  • 📝 Documentation: Docs: Updates to the importing stories into tests #22897
  • 📝 Documentation: Docs: Adds missing snippets args page #23665
  • 📝 Documentation: Documentation: Fix Source's auto description #23531
  • 🏗️ Build: Build: Disable "what's new" notifications when generating sandboxes #23679

🍒 Manual cherry picking needed!

The following pull requests could not be cherry-picked automatically because it resulted in merge conflicts.
For each pull request below, you need to either manually cherry pick it, or discard it by replacing the "patch:yes" label with "patch:no" on the PR and re-generate this PR.

  • #23508: git cherry-pick -m1 -x eab73cfc09ed0aaa00e8f96b164f1faf949e8037
  • #23597: git cherry-pick -m1 -x 2050097519b6dd4ab5f7304c3dbc316da335a4be
  • #23396: git cherry-pick -m1 -x 7e0dabc03a55b57eb04c00b34ac8f6992322c88d
  • #23609: git cherry-pick -m1 -x 5dcc66f19db319ce782b5ef0dd94d1ea284fb674
  • #22450: git cherry-pick -m1 -x 7f56548861e63638419cf3eb6c0bfa0a556231e7
  • #23572: git cherry-pick -m1 -x 39b9548578bd44c216d19c40cf854aabedf6760a
  • #23574: git cherry-pick -m1 -x 77b040cbc8e65763cbd109e803ad1a64e5db88c1
  • #23615: git cherry-pick -m1 -x 46a96b3d02adbe8ec0fab399e1ea498460648102
  • #23630: git cherry-pick -m1 -x a4feb6b1dccbc1b2a14deb8001e66f436246f208
  • #23689: git cherry-pick -m1 -x 708a0847f5fbdabe396903ab7798e8d2b56e41d6

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:


Generated changelog

7.1.2

@github-actions github-actions bot added the release For PRs that trigger new releases. Automated label Jul 25, 2023
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 5 times, most recently from 08b2d0e to b469043 Compare July 25, 2023 12:12
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 5 times, most recently from 1c394d9 to 8f2beff Compare July 26, 2023 10:10
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 5 times, most recently from 2e6f949 to 388efc8 Compare July 26, 2023 14:43
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 5 times, most recently from ca0ff2b to 5153d03 Compare July 28, 2023 09:33
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 2 times, most recently from 38d58da to c2db354 Compare July 31, 2023 13:10
@storybook-bot storybook-bot force-pushed the version-patch-from-7.1.1 branch 8 times, most recently from ebdacff to 04c8732 Compare August 2, 2023 14:04
valentinpalkovic and others added 12 commits August 2, 2023 17:00
…n-of-storybook-in-angular-16.1

Angular: Fix initialization of Storybook in Angular 16.1
(cherry picked from commit 0aec101)
…-documentation

Documentation: Fix snippets regarding module resolution
(cherry picked from commit d4e6098)
Docs: Minor updates to the Environment variables docs
(cherry picked from commit 265f214)
CI: Add missing workflow enum
(cherry picked from commit e59d2c9)
docs: replace unsupported value 'string' in controls
(cherry picked from commit 630ace1)
…ap-require-automigration

Automigration: Fix wrap-require automigration for common js main.js files
(cherry picked from commit dc9ac08)
Maintainance: Fix codeowner docs glob
(cherry picked from commit bf9b17f)
…_changes

Docs: Updates to the importing stories into tests
(cherry picked from commit 67faaf6)
Docs: Adds missing snippets args page
(cherry picked from commit be7e95f)
…ocumentation

Documentation: Fix Source's auto description
(cherry picked from commit 03a3590)
…sandboxes

Build: Disable "what's new" notifications when generating sandboxes
(cherry picked from commit a70dcab)
@vanessayuenn
Copy link
Contributor

@stevus this patch is actually outdated as we released v7.2.1 already, so I will be closing this PR to avoid further confusion. Please check out 7.2.1 instead! Thanks!

@stevus
Copy link

stevus commented Aug 9, 2023

@ndelangen after upgrading to 7.2.1 as advised, I am still seeing the error message appear as noted in

storybookjs/telejson#99 (comment)

image

the Storybook suite in this case no longer crashes, however I was expecting the error message to have been resolved.

@vanessayuenn if the changes from

https://github.com/storybookjs/storybook/pull/23615/files#diff-d269a23d228078c1a42ef4a9c3c5fbe7c159f36787951e5cc9e14249a7e391c3

that should have fixed this in 7.1.2 are not in 7.2.1, then I am afraid this issue is not resolved.

@stevus
Copy link

stevus commented Aug 21, 2023

@vanessayuenn any updates here?

@vanessayuenn
Copy link
Contributor

@stevus this is a PR for an outdated release that contains quite a few bug fixes. I am not sure which one you were waiting on. Can you please open a new issue so it can be triaged? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants