Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tooling: Pick workflow v3 to main #24420

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 9, 2023

What I did

This PR cherry-picks the following to main, to ensure both next and main are in sync in terms of release tooling:

#24382
#24409
4b83597

This needs to be done "manually" like this instead of the regular patch workflow, because this has an effect on the patch workflow.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

JReinhold and others added 3 commits October 9, 2023 22:42
Release tooling: Release stable releases from `latest-release` v3

(cherry picked from commit 3368b85)
Release tooling: Fix `non-patch` renaming

(cherry picked from commit 64e1ac9)
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 9, 2023
@JReinhold JReinhold self-assigned this Oct 9, 2023
@JReinhold JReinhold marked this pull request as ready for review October 9, 2023 20:50
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@octokit/request 8.1.4 None +4 4.81 MB

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know how to review this, but nothing jumped out as looking especially weird given that all this code is coming from next

@JReinhold JReinhold merged commit adddc5d into main Oct 13, 2023
58 of 72 checks passed
@JReinhold JReinhold deleted the pick-release-tooling branch October 13, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants