-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tooling: Release stable releases from latest-release
v3
#24382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
requested review from
ndelangen,
kasperpeulen,
yannbf and
vanessayuenn
as code owners
October 5, 2023 12:10
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
11 tasks
11 tasks
11 tasks
ndelangen
approved these changes
Oct 6, 2023
20 tasks
8 tasks
24 tasks
JReinhold
added a commit
that referenced
this pull request
Oct 9, 2023
Release tooling: Release stable releases from `latest-release` v3 (cherry picked from commit 3368b85)
8 tasks
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Oct 17, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Internal-facing build tooling & test updates
ci:normal
patch:done
Patch/release PRs already cherry-picked to main/release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Continues work on #24106, fixing a few minor bugs with naming and merge conflict handling with
latest-release
.#24106 got reverted, so this includes all its changes as well. Only the last 10 commits need to be reviewed: https://github.com/storybookjs/storybook/pull/24382/files/75e585de951932b1178af510f57c05be9612127a..64bf4b2f871f78a5257021610fb50fe9aeef5410
Checklist for Contributors
Testing
latest-release
): https://github.com/storybookjs/storybook/actions/runs/6419200580/job/17428545288?pr=24382 TEST3 Release: Prerelease 7.5.0-alpha.5 #24385I don't think I can easily do a test run for the publish workflow.
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>