Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Release stable releases from latest-release v3 #24382

Merged
merged 13 commits into from
Oct 9, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 5, 2023

What I did

Continues work on #24106, fixing a few minor bugs with naming and merge conflict handling with latest-release.

#24106 got reverted, so this includes all its changes as well. Only the last 10 commits need to be reviewed: https://github.com/storybookjs/storybook/pull/24382/files/75e585de951932b1178af510f57c05be9612127a..64bf4b2f871f78a5257021610fb50fe9aeef5410

Checklist for Contributors

Testing

I don't think I can easily do a test run for the publish workflow.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold self-assigned this Oct 5, 2023
@JReinhold JReinhold added build Internal-facing build tooling & test updates ci:normal labels Oct 5, 2023
@JReinhold JReinhold marked this pull request as draft October 5, 2023 12:12
@JReinhold JReinhold temporarily deployed to release October 5, 2023 12:18 — with GitHub Actions Inactive
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@octokit/request 8.1.2 None +4 4.81 MB octokitbot

@JReinhold JReinhold temporarily deployed to release October 5, 2023 12:29 — with GitHub Actions Inactive
@JReinhold JReinhold temporarily deployed to release October 5, 2023 12:44 — with GitHub Actions Inactive
@JReinhold JReinhold temporarily deployed to release October 6, 2023 09:34 — with GitHub Actions Inactive
@JReinhold JReinhold marked this pull request as ready for review October 6, 2023 09:37
@JReinhold JReinhold merged commit 3368b85 into next Oct 9, 2023
52 of 53 checks passed
@JReinhold JReinhold deleted the release-to-latest-v2 branch October 9, 2023 07:19
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
20 tasks
@github-actions github-actions bot mentioned this pull request Oct 9, 2023
24 tasks
JReinhold added a commit that referenced this pull request Oct 9, 2023
Release tooling: Release stable releases from `latest-release` v3

(cherry picked from commit 3368b85)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants