Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Test Coverage troubleshoot optimized builds #25278

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jonniebigodes
Copy link
Contributor

Addresses #25205

What I did

With this small pull request, the test coverage documentation was updated to factor in a small troubleshooting item to address the mentioned issue.

What was done:

  • Created the required snippets
  • Adjusted the documentation based on the proposed wording.

Going to merge this as soon as the checklist clears to allow it to be available to be linked into a post incoming this week

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch ci:docs Run the CI jobs for documentation checks only. labels Dec 19, 2023
@jonniebigodes jonniebigodes self-assigned this Dec 19, 2023
@jonniebigodes jonniebigodes merged commit 4495fa9 into next Dec 19, 2023
18 of 23 checks passed
@jonniebigodes jonniebigodes deleted the docs_add_test_troubleshooting branch December 19, 2023 21:17
storybook-bot pushed a commit that referenced this pull request Dec 19, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 20, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 21, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 22, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 22, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 22, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 24, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 28, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
storybook-bot pushed a commit that referenced this pull request Dec 29, 2023
Docs: Test Coverage troubleshoot optimized builds
(cherry picked from commit 4495fa9)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant