Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Semver dependency fixes #25283

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Dependencies: Semver dependency fixes #25283

merged 2 commits into from
Dec 21, 2023

Conversation

ndelangen
Copy link
Member

What I did

  • semver doesn't bundle well for react-native
  • semver should be paired with @types/semver always

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen changed the title Dependensies: Semver dependency fixes Dependencies: Semver dependency fixes Dec 20, 2023
@ndelangen ndelangen self-assigned this Dec 20, 2023
@ndelangen ndelangen added maintenance User-facing maintenance tasks ci:normal labels Dec 20, 2023
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 21, 2023
@shilman shilman merged commit c92a672 into next Dec 21, 2023
59 of 60 checks passed
@shilman shilman deleted the norbert/bundle-semver branch December 21, 2023 11:30
shilman added a commit that referenced this pull request Dec 30, 2023
Dependencies: Semver dependency fixes
(cherry picked from commit c92a672)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants