Vite: Fix pre-transform error in Vite 5 #25329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
bug
patch:yes
yannbf
requested review from
JReinhold,
valentinpalkovic and
IanVS
as code owners
kasperpeulen
approved these changes
Dec 28, 2023
9 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 28, 2023
…ite-5 Vite: Fix pre-transform error in Vite 5 (cherry picked from commit aa0b69c)
Merged
11 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
…ite-5 Vite: Fix pre-transform error in Vite 5 (cherry picked from commit aa0b69c)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
…ite-5 Vite: Fix pre-transform error in Vite 5 (cherry picked from commit aa0b69c)
storybook-bot
pushed a commit
that referenced
this pull request
Dec 29, 2023
…ite-5 Vite: Fix pre-transform error in Vite 5 (cherry picked from commit aa0b69c)
github-actions
bot
added
the
patch:done
mbao01
added a commit
to mbao01/mbao01
that referenced
this pull request
Jan 19, 2024
Issu with sb-preview - see fix here storybookjs/storybook#25329
mbao01
added a commit
to mbao01/mbao01
that referenced
this pull request
Jan 19, 2024
Issu with sb-preview - see fix here storybookjs/storybook#25329
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25256
What I did
This PR adds a configuration to vite so that assets handled via Storybook's express server are ignored, therefore resolving the following error:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-25329-sha-028652d7. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25329-sha-028652d7yann/pre-transform-error-vite-5028652d71703700514)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25329