-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Downgrade to esbuild 0.24.0 #30116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
@@ -185,7 +185,7 @@ | |||
"cross-env": "^7.0.3", | |||
"danger": "^12.3.3", | |||
"es-toolkit": "^1.22.0", | |||
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0", | |||
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider keeping version range for dependencies to avoid potential conflicts with other packages requiring different esbuild versions. Pinning in resolutions should be sufficient.
@@ -277,7 +277,7 @@ | |||
"@storybook/csf": "0.1.12", | |||
"better-opn": "^3.0.2", | |||
"browser-assert": "^1.2.1", | |||
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0", | |||
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Pinning esbuild to exactly 0.24.0 instead of allowing newer patch versions could prevent getting important bug fixes. Consider using ^0.24.0 instead.
@@ -54,7 +54,7 @@ | |||
] | |||
}, | |||
"resolutions": { | |||
"esbuild": "^0.24.0", | |||
"esbuild": "0.24.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Pinning esbuild to exact version 0.24.0 may miss critical security patches. Consider using ~0.24.0 to allow patch updates
View your CI Pipeline Execution ↗ for commit a8a20ff.
☁️ Nx Cloud last updated this comment at |
Closes #
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
Downgraded esbuild to version 0.24.0 across multiple package.json files to address CI issues while maintaining backward compatibility with existing build processes.
code/package.json
resolutions and dependenciescode/core/package.json
to pin esbuild to 0.24.0 while preserving compatibility with versions 0.18.0-0.23.0scripts/package.json
to use exact version 0.24.0 instead of caret range