Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Downgrade to esbuild 0.24.0 #30116

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 20, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 439 B 2.98 0%
initSize 133 MB 133 MB -260 B -4.36 0%
diffSize 55.3 MB 55.3 MB -699 B -4.36 0%
buildSize 7.23 MB 7.23 MB 0 B -2.28 0%
buildSbAddonsSize 1.86 MB 1.86 MB 0 B -2.38 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 0 B 1.73 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.92 MB 3.92 MB 0 B -2.28 0%
buildPreviewSize 3.3 MB 3.3 MB 0 B -0.47 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 14.9s 22.2s 7.2s 1.07 32.8%
generateTime 19.8s 18.6s -1s -192ms -1.49 🔰-6.4%
initTime 13.9s 12.9s -1s -6ms -1.61 🔰-7.8%
buildTime 8.5s 9s 530ms -0.71 5.9%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 4.8s 6.2s 1.3s 1.13 22.3%
devManagerResponsive 3.5s 4.1s 572ms 0.23 13.9%
devManagerHeaderVisible 582ms 751ms 169ms 0.56 22.5%
devManagerIndexVisible 610ms 782ms 172ms 0.45 22%
devStoryVisibleUncached 1.7s 1.7s -73ms -0.42 -4.3%
devStoryVisible 611ms 783ms 172ms 0.47 22%
devAutodocsVisible 484ms 528ms 44ms -0.48 8.3%
devMDXVisible 502ms 630ms 128ms 0.29 20.3%
buildManagerHeaderVisible 548ms 708ms 160ms 0.13 22.6%
buildManagerIndexVisible 640ms 818ms 178ms 0.17 21.8%
buildStoryVisible 537ms 684ms 147ms 0.31 21.5%
buildAutodocsVisible 434ms 533ms 99ms 0.21 18.6%
buildMDXVisible 446ms 553ms 107ms 0.48 19.3%

Greptile Summary

Downgraded esbuild to version 0.24.0 across multiple package.json files to address CI issues while maintaining backward compatibility with existing build processes.

  • Fixed esbuild version to 0.24.0 in code/package.json resolutions and dependencies
  • Updated code/core/package.json to pin esbuild to 0.24.0 while preserving compatibility with versions 0.18.0-0.23.0
  • Modified scripts/package.json to use exact version 0.24.0 instead of caret range
  • Ensures consistent esbuild version across the monorepo to prevent CI build failures

@yannbf yannbf added dependencies maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 20, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

@@ -185,7 +185,7 @@
"cross-env": "^7.0.3",
"danger": "^12.3.3",
"es-toolkit": "^1.22.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider keeping version range for dependencies to avoid potential conflicts with other packages requiring different esbuild versions. Pinning in resolutions should be sufficient.

@@ -277,7 +277,7 @@
"@storybook/csf": "0.1.12",
"better-opn": "^3.0.2",
"browser-assert": "^1.2.1",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Pinning esbuild to exactly 0.24.0 instead of allowing newer patch versions could prevent getting important bug fixes. Consider using ^0.24.0 instead.

@@ -54,7 +54,7 @@
]
},
"resolutions": {
"esbuild": "^0.24.0",
"esbuild": "0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Pinning esbuild to exact version 0.24.0 may miss critical security patches. Consider using ~0.24.0 to allow patch updates

Copy link

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit a8a20ff.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 12:05:00 UTC

@valentinpalkovic valentinpalkovic merged commit 5b7be19 into next Dec 20, 2024
63 of 66 checks passed
@valentinpalkovic valentinpalkovic deleted the yann/fix-esbuild-ci-issue branch December 20, 2024 12:31
@yannbf yannbf removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants