Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Downgrade to esbuild 0.24.0 #30116

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Build: Downgrade to esbuild 0.24.0 #30116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@
"@storybook/csf": "0.1.12",
"better-opn": "^3.0.2",
"browser-assert": "^1.2.1",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Pinning esbuild to exactly 0.24.0 instead of allowing newer patch versions could prevent getting important bug fixes. Consider using ^0.24.0 instead.

"esbuild-register": "^3.5.0",
"jsdoc-type-pratt-parser": "^4.0.0",
"process": "^0.11.10",
Expand Down
4 changes: 2 additions & 2 deletions code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"@types/babel__traverse@npm:^7.18.0": "patch:@types/babel__traverse@npm%3A7.20.6#~/.yarn/patches/@types-babel__traverse-npm-7.20.6-fac4243243.patch",
"@types/node": "^22.0.0",
"@vitest/expect@npm:2.0.5": "patch:@vitest/expect@npm%3A2.0.5#~/.yarn/patches/@vitest-expect-npm-2.0.5-8933466cce.patch",
"esbuild": "^0.24.0",
"esbuild": "0.24.0",
"playwright": "1.48.1",
"playwright-core": "1.48.1",
"serialize-javascript": "^3.1.0",
Expand Down Expand Up @@ -185,7 +185,7 @@
"cross-env": "^7.0.3",
"danger": "^12.3.3",
"es-toolkit": "^1.22.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider keeping version range for dependencies to avoid potential conflicts with other packages requiring different esbuild versions. Pinning in resolutions should be sufficient.

"esbuild-loader": "^4.2.0",
"esbuild-plugin-alias": "^0.2.1",
"eslint": "8.57.1",
Expand Down
4 changes: 2 additions & 2 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7125,7 +7125,7 @@ __metadata:
cross-env: "npm:^7.0.3"
danger: "npm:^12.3.3"
es-toolkit: "npm:^1.22.0"
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || ^0.24.0"
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0 || ^0.21.0 || ^0.22.0 || ^0.23.0 || 0.24.0"
esbuild-loader: "npm:^4.2.0"
esbuild-plugin-alias: "npm:^0.2.1"
eslint: "npm:8.57.1"
Expand Down Expand Up @@ -14518,7 +14518,7 @@ __metadata:
languageName: node
linkType: hard

"esbuild@npm:^0.24.0":
"esbuild@npm:0.24.0":
version: 0.24.0
resolution: "esbuild@npm:0.24.0"
dependencies:
Expand Down
4 changes: 2 additions & 2 deletions scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
]
},
"resolutions": {
"esbuild": "^0.24.0",
"esbuild": "0.24.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Pinning esbuild to exact version 0.24.0 may miss critical security patches. Consider using ~0.24.0 to allow patch updates

"serialize-javascript": "^3.1.0",
"type-fest": "~2.19"
},
Expand Down Expand Up @@ -108,7 +108,7 @@
"ejs": "^3.1.10",
"ejs-lint": "^2.0.0",
"es-toolkit": "^1.22.0",
"esbuild": "^0.24.0",
"esbuild": "0.24.0",
"esbuild-plugin-alias": "^0.2.1",
"eslint": "^8.57.0",
"eslint-config-airbnb-typescript": "^18.0.0",
Expand Down
4 changes: 2 additions & 2 deletions scripts/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,7 +1450,7 @@ __metadata:
ejs: "npm:^3.1.10"
ejs-lint: "npm:^2.0.0"
es-toolkit: "npm:^1.22.0"
esbuild: "npm:^0.24.0"
esbuild: "npm:0.24.0"
esbuild-plugin-alias: "npm:^0.2.1"
eslint: "npm:^8.57.0"
eslint-config-airbnb-typescript: "npm:^18.0.0"
Expand Down Expand Up @@ -5143,7 +5143,7 @@ __metadata:
languageName: node
linkType: hard

"esbuild@npm:^0.24.0":
"esbuild@npm:0.24.0":
version: 0.24.0
resolution: "esbuild@npm:0.24.0"
dependencies:
Expand Down
Loading