Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to fail on console errors #321

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

work933k
Copy link
Contributor

@work933k work933k commented Jun 21, 2023

Hi,

This Pull-Requests adds browser-console error-checking to the test-runner. To have this as a command-line parameter is much easier than having to eject the configuration.

The feature is non-breaking implemented. Not providing --checkConsole should keep functionality as-is.

Hopefully you'll consider merging this Pull-Request..

Thanks in advance!

Version

Published prerelease version: v0.13.0-next.2

Changelog

🚀 Enhancement

🐛 Bug Fix

Authors: 3

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1238e65) 76.66% compared to head (542f0b2) 76.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #321   +/-   ##
=======================================
  Coverage   76.66%   76.66%           
=======================================
  Files          11       11           
  Lines         180      180           
  Branches       40       40           
=======================================
  Hits          138      138           
  Misses         42       42           
Files Changed Coverage Δ
src/util/getCliOptions.ts 65.00% <ø> (ø)
src/util/getParsedCliOptions.ts 6.25% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yannbf yannbf changed the title Added console-error-checking Add ability to fail on console errors Aug 4, 2023
@yannbf
Copy link
Member

yannbf commented Aug 4, 2023

Hey @work933k I love this contribution. Thank you so much! I worked a little on top of it to make sure the errors are properly logged, that we test this in CI as well as renamed it to failOnConsole so that it tells its intent more directly. Maybe in the future people will request to be able to define levels of failures e.g.

  • only on errors
  • warnings (+errors)
  • log (+warnings, +errors)

But for now only errors makes sense to me! Thanks once again <3

@yannbf yannbf added the minor Increment the minor version when merged label Aug 4, 2023
@yannbf yannbf merged commit 5cce841 into storybookjs:next Aug 4, 2023
9 checks passed
@yannbf yannbf mentioned this pull request Aug 4, 2023
@github-actions
Copy link

github-actions bot commented Aug 4, 2023

🚀 PR was released in v0.13.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants