-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support importing stories from separate packages #339
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## next #339 +/- ##
=======================================
Coverage 77.17% 77.17%
=======================================
Files 11 11
Lines 184 184
Branches 39 39
=======================================
Hits 142 142
Misses 42 42
☔ View full report in Codecov by Sentry. |
6f8f876
to
917655f
Compare
917655f
to
848d743
Compare
a1fbdb1
to
8a745f5
Compare
🚀 PR was released in |
Does this fix the coverage collection too? so if i have a monorepo with stories in each package, it will collect the coverage from the files in each package? |
Hey there, great question! It could probably fix it, but it also depends on how the file inclusion is done in the coverage addon in combination with your repo structure. Could you please try it out and open an issue with a reproduction in case it won't work? Thanks! |
Closes #133
This PR adds a fix that aims to provide support for importing stories from separate packages such as is commonly done in monorepos:
e.g. this project structure:
and this storybook config file:
📦 Published PR as canary version:
0.12.1--canary.339.90fb7b2.0
✨ Test out this PR locally via:
npm install @storybook/test-runner@0.12.1--canary.339.90fb7b2.0 # or yarn add @storybook/test-runner@0.12.1--canary.339.90fb7b2.0
Version
Published prerelease version:
v0.13.0-next.0
Changelog
🚀 Enhancement
Authors: 1