Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dependencies #72

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Cleanup dependencies #72

merged 1 commit into from
Mar 6, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 6, 2022

closes #69

What I did

  • Added missing deps
  • Cleaned out a few redundant deps using npx depcheck

How to test

  • CI passes

@shilman shilman added the dependencies Update one or more dependencies version label Mar 6, 2022
@shilman shilman requested a review from yannbf March 6, 2022 09:39
yannbf
yannbf approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@yannbf yannbf merged commit 103ceca into next Mar 6, 2022
@github-actions github-actions bot mentioned this pull request Mar 13, 2022
Merged
1 task
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
Merged
@yannbf yannbf mentioned this pull request Apr 7, 2022
Merged
@yannbf yannbf deleted the fix/cleanup-deps branch November 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
dependencies Update one or more dependencies version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] TypeError: (0 , _coreCommon.normalizeStories) is not a function
2 participants
@shilman @yannbf