Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to test docs pages via VIEW_MODE env var #79

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 12, 2022

What I did

  • Add a new VIEW_MODE env var for running tests against docs pages

How to test

Run a storybook that supports stories.json e.g. from the monorepo

Then run snapshot tests against it, e.g.

 VIEW_MODE=docs yarn test-storybook:no-cache --url http://localhost:9006 --stories-json

Version

Published prerelease version: v0.0.5-next.1

Changelog

🐛 Bug Fix

  • Add ability to test docs pages via VIEW_MODE env var #79 (@shilman)
  • cleanup jsdom related code #67 (@yannbf)

🔩 Dependency Updates

Authors: 2

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 99fc56d into next Mar 13, 2022
@shilman shilman deleted the feat/add-docs-view-mode branch March 13, 2022 17:47
@github-actions github-actions bot mentioned this pull request Apr 7, 2022
@yannbf yannbf mentioned this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants