-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Reduce installation noise and improve error handling #22554
Conversation
a670366
to
5709e45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @yannbf -- was going to ask for this as a next step to the error handling project but you beat me to it. 😅
RE: UX can we show a CLI spinner while the installation is occurring now that we're swallowing all the installer output? Also we probably need to handle |
04ac08c
to
b201226
Compare
TODO: Move
And make sure this yields the correct result when users do Ctrl + C in the middle of init, rather than generate an error that is unrelated! |
…-noise CLI: Reduce installation noise and improve error handling
Closes #22343
What I did
Before, errors thrown by
addDeps
from our package manager proxies would always look something like this, without proper explanation:In this PR, I do a few things:
ora
package to display spinner in the CLI (now that users don't see progress they might end up quitting the CLI if we don't display a spinner)Before:
After (example for each package manager):
And an example of how the log file looks like:
Spinners in action:
How to test
STORYBOOK_DISABLE_TELEMETRY=true storybook init
command (using the built binary) in thosewhen testing the
init
command, you can also pass a package manager via the--package-manager
flagChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]