Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time.Time comparison produces non-helpful diff #989

Closed
AlekSi opened this issue Aug 1, 2020 · 5 comments · Fixed by #1072
Closed

time.Time comparison produces non-helpful diff #989

AlekSi opened this issue Aug 1, 2020 · 5 comments · Fixed by #1072
Assignees
Labels
Projects

Comments

@AlekSi
Copy link
Contributor

AlekSi commented Aug 1, 2020

#895 broke diffs with time.Time:

In 1.5.1:

-    Created: (xxx.Time) 2020-01-14T06:23:58Z,
-    Modified: (xxx.Time) 2020-01-14T06:23:58Z,
+    Created: (xxx.Time) 2018-08-05T09:30:53Z,
+    Modified: (xxx.Time) 2019-04-11T04:28:50Z,

In 1.6.1:

@@ -13,3 +13,3 @@
        wall: (uint64) 0,
-      ext: (int64) 63714579838,
+      ext: (int64) 63669058253,
        loc: (*time.Location)(<nil>)
@@ -20,3 +20,3 @@
        wall: (uint64) 0,
-      ext: (int64) 63714579838,
+      ext: (int64) 63690553730,
        loc: (*time.Location)(<nil>)
@jwoloch
Copy link

jwoloch commented Sep 16, 2020

Can we expect a minor release with #895, before 1.7.0?

@boyan-soubachov
Copy link
Collaborator

Can we expect a minor release with #895, before 1.7.0?

go get github.com/stretchr/testify@master will get you the latest version on master :)

@AlekSi
Copy link
Contributor Author

AlekSi commented Sep 25, 2020

#895 was released in 1.6.0 and was the source of this problem, not solution

@jwoloch
Copy link

jwoloch commented Oct 3, 2020

sorry, I meant fix for the issue produced by #895.

@HaraldNordgren
Copy link
Contributor

@AlekSi @Jozmen @boyan-soubachov Fix proposed here if you want to take a look :) #1072

HaraldNordgren added a commit to HaraldNordgren/testify that referenced this issue Apr 24, 2021
HaraldNordgren added a commit to HaraldNordgren/testify that referenced this issue Apr 24, 2021
Bugs automation moved this from Needs triage to Closed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Bugs
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants